Skip to content

chore(deps): update dependency tap to v21 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update dependency tap to v21 #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"rimraf": "^2.2.8",
"server-destroy": "^1.0.1",
"standard": "^9.0.0",
"tap": "^15.1.5",
"tap": "^21.0.0",

@cursor cursor Bot Mar 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed --no-check-coverage flag breaks test-ci script

High Severity

Upgrading tap from ^15 to ^21 without updating the test-ci script breaks the test runner. The --no-check-coverage flag used in "test-ci": "tap --no-check-coverage tests/test-*.js" was removed in tap v18's major overhaul. In tap v18+, coverage configuration changed entirely — the replacement options are --allow-incomplete-coverage or --disable-coverage. Running the existing script with tap v21 will fail with an unrecognized option error.

Additional Locations (1)

Fix in Cursor Fix in Web

@cursor cursor Bot Apr 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tap v21 requires Node 20 but CI uses Node 18

High Severity

Bumping tap to v21 requires Node.js >=20.0.0, but our CI environments still run Node 18. This causes tap to fail during test runs in CI.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2641cc9. Configure here.

@cursor cursor Bot May 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed CLI flag breaks test-ci script with tap v21

High Severity

Upgrading tap from v15 to v21 breaks the test-ci script at line 50, which uses tap --no-check-coverage tests/test-*.js. The --no-check-coverage CLI flag was removed in tap v18's complete rewrite. In tap v21, the equivalent options are --disable-coverage combined with --allow-empty-coverage, or --allow-incomplete-coverage. The test command will fail with an unrecognized option error. Additionally, tap v21 requires Node.js v20+, while this project declares support for Node.js >= 14.17.0.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8d45206. Configure here.

"tape": "^4.6.0"
},
"greenkeeper": {
Expand Down
Loading
Loading