fix: use struct field for deprecated metrics and guard against division by zero#146
Open
Aprazor wants to merge 1 commit intoczerwonk:mainfrom
Open
fix: use struct field for deprecated metrics and guard against division by zero#146Aprazor wants to merge 1 commit intoczerwonk:mainfrom
Aprazor wants to merge 1 commit intoczerwonk:mainfrom
Conversation
…on by zero Two fixes in Collect(): 1. Use p.enableDeprecatedMetrics (struct field) instead of the package-level enableDeprecatedMetrics variable, matching the pattern already used in Describe(). 2. Skip targets with PacketsSent == 0 to avoid emitting NaN for the loss metric (0/0 in IEEE 754).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in Collect():
package-level enableDeprecatedMetrics variable, matching the
pattern already used in Describe().
the loss metric (0/0 in IEEE 754).