fix: check correct variable in test guard conditions#148
Open
Aprazor wants to merge 1 commit intoczerwonk:mainfrom
Open
fix: check correct variable in test guard conditions#148Aprazor wants to merge 1 commit intoczerwonk:mainfrom
Aprazor wants to merge 1 commit intoczerwonk:mainfrom
Conversation
The guards checked len(ipv4Addr) and len(ipv6Addr) (localhost results) instead of len(ipv4AddrGoogle) and len(ipv6AddrGoogle). If the Google lookups returned empty, tests would continue and panic on ipv4AddrGoogle[0] access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guards checked len(ipv4Addr) and len(ipv6Addr) (localhost
results) instead of len(ipv4AddrGoogle) and len(ipv6AddrGoogle).
If the Google lookups returned empty, tests would continue and
panic on ipv4AddrGoogle[0] access.