fix(classifier): avoid forcing unsupported temperature#2
Open
tank-bohr wants to merge 1 commit into
Open
Conversation
Let classifier providers use their default temperature unless a caller explicitly supplies one. Some providers, including OpenAI Codex, reject the parameter entirely. Treat provider-reported completion errors as classifier failures instead of retrying them as malformed JSON, and retain the provider message in classifier I/O logs.
1bc95a4 to
d425d00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Classifier calls currently force
temperature: 0. Providers that do not support the parameter, including OpenAI Codex, reject the request before classification:pi-airepresents this as an assistant response withstopReason: "error". The classifier then treats the empty response body as malformed JSON, retries the same request, and reports a misleading invalid-JSON failure.Changes
Verification
npm run checknpm test(65 tests)npm pack --dry-runopenai-codex/gpt-5.6-solwith no temperature override returned a valid allow decision.