Ensure that niced domains always span ticks

[domoritz]

fixes #209

[mbostock]

Now the question is there any situation we aren’t anticipating that will go into an infinite loop. :)

[jheer]

import {halts} from ‘halting-problem’;

Or instead perhaps a reasonable maxiter value?

[domoritz]

We could attempt to prove that this specific code will always halt but better be safe. I added a commit to limit the number of iterations with maxiter as @jheer suggested.

[mbostock]

I think my preference is to prove that it will always halt, but that requires more mental effort. :)

[domoritz]

Ideally, we would prove it for all future versions of the code as well.

[jheer]

Everyone please be considerate. The maxiter suggestion is designed to make sure eslint feels consulted and content.

[domoritz]

@mbostock I'm happy with the code. Is there anything you want me to change?

[domoritz]

@mbostock could you include this patch in a release?

[curran]

The logic appears sound. The incidental var --> const/let changes will make the codebase internally inconsistent. Maybe use var everywhere? I'm all for ES6 migration, but maybe that would be best to do on all modules at once, as a separate PR.

[domoritz]

I went back to var and will send a separate pull request switching to let/const.

[curran]

Nice! Related https://github.com/d3/d3-array/issues/153#issuecomment-644193932

[domoritz]

I sent #212

[domoritz]

Anything else you want me to change @mbostock @curran @Fil?

[Fil]

LGTM

[domoritz]

Thanks for the reviews @curran and @Fil. @mbostock can you include this fix in a release?

[domoritz]

ping @curran @Fil @mbostock

[Fil]

yes I think so—we're currently preparing a rather big release (ie d3v6)

[domoritz]

🎉 Awesome. Looking forward to it.