Skip to content

fix: batch_merge crashes with AnnotatedJoin has no attribute _autoincrement_column on joined-table inheritance #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d3vyce merged 1 commit into from
Jul 7, 2026
Merged

fix: batch_merge crashes with AnnotatedJoin has no attribute _autoincrement_column on joined-table inheritance #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/fastapi_toolsets/fixtures/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,13 @@ async def _batch_merge(
) -> None:
"""UPSERT: insert new rows, update existing ones with the provided values."""
for cls, group_dicts, _ in _grouped_table_dicts(model_cls, instances):
pk_names = [col.name for col in cls.__table__.primary_key]
table = cast(Table, cls.__table__)
pk_names = [col.name for col in table.primary_key]
pk_names_set = set(pk_names)
own_col_keys = {col.key for col in cls.__table__.columns}
own_col_keys = {col.key for col in table.columns}
non_pk_cols = [k for k in own_col_keys if k not in pk_names_set]

stmt = pg_insert(cls).values(group_dicts)
stmt = pg_insert(table).values(group_dicts)

inserted_keys = set(group_dicts[0])
update_cols = [col for col in non_pk_cols if col in inserted_keys]
Expand Down