Skip to content

Support more integer type conversions#197

Merged
d99kris merged 2 commits intod99kris:integrate-more-int-typesfrom
Yurunsoft:support-int-types
Jan 11, 2026
Merged

Support more integer type conversions#197
d99kris merged 2 commits intod99kris:integrate-more-int-typesfrom
Yurunsoft:support-int-types

Conversation

@Yurunsoft
Copy link
Contributor

No description provided.

@d99kris d99kris self-assigned this Dec 30, 2025
@Yurunsoft
Copy link
Contributor Author

@d99kris This PR provides support for the following types: int8_t, uint8_t, int16_t, uint16_t.

@d99kris
Copy link
Owner

d99kris commented Jan 11, 2026

Hello @Yurunsoft - thanks for contributing! Generally the changes look good. I would prefer to minimize change to existing test code lines though. And for ToStr() I believe there's an issue for signed char and unsigned char - default iostream will output them as characters (not numbers), so we need separate handling similar to the floating-point types (but just casting to int before print). Finally I'd like to add a test case that covers that (ToStr / Set for all datatypes).

I'll merge the PR to an integration branch and make the above mentioned changes, and add a message here when it's fully integrated to rapidcsv master.

@d99kris d99kris changed the base branch from master to integrate-more-int-types January 11, 2026 09:38
@d99kris d99kris merged commit 376b317 into d99kris:integrate-more-int-types Jan 11, 2026
3 checks passed
d99kris added a commit that referenced this pull request Jan 11, 2026
* support more integer type conversions (#197)

* Support more integer type conversions

* remove unsigned int

* follow-up to 376b317 - minimize test changes, fix ToStr handling of char types, add test for setting all numerical data types

---------

Co-authored-by: Yurun <admin@yurunsoft.com>
@d99kris
Copy link
Owner

d99kris commented Jan 11, 2026

This has been integrated to rapidcsv master in commit 9b660bc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants