[codex] Add bounds selection support

.github/workflows/tests-and-lint.yml

@@ -0,0 +1,35 @@
+name: Tests and Lint
+
+on:
+  push:
+    branches: ["main"]
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  quality:
+    name: Tests and lint
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout JS client
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+
+      - name: Enable Corepack
+        run: corepack enable
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Run lint
+        run: yarn lint
+
+      - name: Run tests
+        run: yarn test:ci

README.md

@@ -140,6 +140,27 @@ const [subset, metadata] = await client.selectDataset({
 });
 ```
 
+Use `bounds` for rectangular lon/lat selections. Tuple bounds are
+`[west, south, east, north]`.
+
+```typescript
+const [westernEurope, metadata] = await client.selectDataset({
+  request: {
+    organization: "ecmwf",
+    collection: "era5",
+    dataset: "temperature_2m",
+    variant: "finalized"
+  },
+  selection: {
+    bounds: [-12, 35, 16, 60],
+    timeRange: {
+      start: "2024-01-01T00:00:00Z",
+      end: "2024-01-07T23:00:00Z",
+    },
+  }
+});
+```
+
 ### Geographic shape selections
 
 The client supports advanced geographic selections beyond single points:

eslint.config.js

@@ -0,0 +1,24 @@
+import js from "@eslint/js";
+import globals from "globals";
+import tseslint from "typescript-eslint";
+
+export default tseslint.config(
+  {
+    ignores: ["coverage/**", "dist/**", "node_modules/**"],
+  },
+  js.configs.recommended,
+  ...tseslint.configs.recommended,
+  {
+    files: ["**/*.ts", "**/*.js"],
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+      },
+    },
+    rules: {
+      "@typescript-eslint/no-this-alias": "off",
+      "no-undef": "off",
+    },
+  },
+);

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dclimate/dclimate-client-js",
-  "version": "0.5.7",
+  "version": "0.5.8",
   "description": "JavaScript client for dClimate datasets using jaxray and IPFS stores",
   "type": "module",
   "main": "./dist/node/index.js",
@@ -26,7 +26,9 @@
     "build:browser": "tsc -p tsconfig.browser.json",
     "build:node": "tsc -p tsconfig.node.json",
     "build": "npm run build:browser && npm run build:node",
+    "lint": "eslint .",
     "test": "vitest",
+    "test:ci": "vitest run",
     "test:coverage": "vitest run --coverage",
     "prepare": "npm run build",
     "prepublishOnly": "npm run build"
@@ -53,7 +55,11 @@
     "@opentelemetry/api": "^1.9.1"
   },
   "devDependencies": {
+    "@eslint/js": "10.0.1",
+    "eslint": "10.4.1",
+    "globals": "17.6.0",
     "typescript": "^5.4.0",
+    "typescript-eslint": "8.61.0",
     "vitest": "^4.1.0"
   },
   "publishConfig": {

src/client.ts

@@ -161,16 +161,16 @@ export class DClimateClient {
           request.variant,
           resolvedOrganization
         );
-        resolvedCollection = resolvedInfo.collectionId;
-        resolvedOrganization = resolvedInfo.organizationId ?? resolvedOrganization;
+        const resolvedOrganizationId =
+          resolvedInfo.organizationId ?? resolvedOrganization;
 
         // Multiple variants with concat metadata found
         // Load and concatenate based on dclimate:concatPriority
         return this.loadAndConcatenateVariants(
           {
             ...request,
             collection: resolvedInfo.collectionId,
-            organization: resolvedInfo.organizationId ?? resolvedOrganization,
+            organization: resolvedOrganizationId,
             variant: request.variant,
           },
           concatenableItems,
@@ -184,7 +184,6 @@ export class DClimateClient {
 
     // Fall back to single variant loading
     let cid: string | null = null;
-    let resolvedPath: string;
     let metadataDataset = request.dataset;
     let metadataCollection = resolvedCollection || request.collection;
     let metadataVariant = request.variant ?? "";
@@ -231,7 +230,7 @@ export class DClimateClient {
 
     // Build path from resolved names
     const pathParts = [metadataCollection, metadataDataset, metadataVariant].filter(Boolean);
-    resolvedPath = pathParts.join("-");
+    const resolvedPath = pathParts.join("-");
 
     const dataset = await openDatasetFromCid(cid, {
       gatewayUrl,