Fix dataset prefix matching in STAC server#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the accuracy and robustness of dataset resolution for ERA5 and ERA5-Land datasets, ensuring that dataset IDs are matched exactly rather than by prefix. This prevents accidental conflation of similar dataset names (such as
precipitation_totalandprecipitation_total_land). It also adds comprehensive tests to verify this behavior and updates the documentation to clarify how to load these datasets.Dataset resolution improvements:
src/stac/stac-server.tsto use a newfeatureMatchesDatasetfunction, ensuring that datasets are matched exactly rather than by prefix, preventing collisions between similar dataset names (e.g.,precipitation_totalvs.precipitation_total_land). [1] [2]datasetIdFromItemIdto extract dataset IDs from item IDs for legacy fallback, ensuring exact matches only.Testing enhancements:
tests/stac-server.test.tsto verify that only exact dataset matches are resolved and that prefix collisions do not occur. Tests cover both positive and negative cases as well as legacy item ID fallback.Documentation updates:
README.mdto clarify the distinction between ERA5 and ERA5-Land datasets and provided example code for loading each type, helping users avoid dataset confusion.Test infrastructure:
afterEachandvifor better test isolation and mocking.