Add num_contracheques field in update GetGeneralSummary handler#594
Merged
Add num_contracheques field in update GetGeneralSummary handler#594
Conversation
rdurl0
requested changes
Jun 24, 2025
| @@ -702,6 +702,10 @@ func (h handler) GetGeneralSummary(c echo.Context) error { | |||
| if err != nil { | |||
| return c.JSON(http.StatusInternalServerError, fmt.Sprintf("Erro ao contar registros de meses coletados: %q", err)) | |||
| } | |||
There was a problem hiding this comment.
Tem algo aqui que deu erro no GitHub Actions
Check failure on line 705 in uiapi/handlers.go
GitHub Actions
/ testing
h.client.Db.GetNumberOfPaychecksCollected undefined (type database.Interface has no field or method GetNumberOfPaychecksCollected)
Contributor
There was a problem hiding this comment.
O erro ocorre pois depende da versão atualizada do storage (que ainda estava em revisão), após o merge do storage e atualização das dependências deste repo, deve ficar tudo ok.
Contributor
Author
There was a problem hiding this comment.
Exato, por isso que esse PR depende do storage ser mergeado primeiro, @rdurl0
Contributor
joellensilva
left a comment
joellensilva
left a comment
There was a problem hiding this comment.
Muito bom! Lembre de atualizar a versão do storage antes de mergear.
uiapi/handlers.go
Outdated
| if err != nil { | ||
| return c.JSON(http.StatusInternalServerError, fmt.Sprintf("Erro ao contar registros de meses coletados: %q", err)) | ||
| } | ||
| paychechs, err := h.client.Db.GetNumberOfPaychecksCollected() |
Contributor
There was a problem hiding this comment.
Suggested change
| paychechs, err := h.client.Db.GetNumberOfPaychecksCollected() | |
| paychecks, err := h.client.Db.GetNumberOfPaychecksCollected() |
uiapi/handlers.go
Outdated
| return c.JSON(http.StatusOK, generalSummary{ | ||
| Agencies: int(agencies), | ||
| MonthlyInfos: int(collections), | ||
| Paychecks: int(paychechs), |
Contributor
There was a problem hiding this comment.
Suggested change
| Paychecks: int(paychechs), | |
| Paychecks: int(paychecks), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retornando o número total de contracheques coletados
depends on dadosjusbr/storage/pull/149