Maps: add MapKeys, MapValues, and related helpers#86
Open
alex-chew wants to merge 14 commits intodafny-lang:masterfrom
Open
Maps: add MapKeys, MapValues, and related helpers#86alex-chew wants to merge 14 commits intodafny-lang:masterfrom
alex-chew wants to merge 14 commits intodafny-lang:masterfrom
Conversation
davidcok
previously approved these changes
Feb 13, 2023
MikaelMayer
reviewed
Feb 15, 2023
Member
MikaelMayer
left a comment
MikaelMayer
left a comment
There was a problem hiding this comment.
Minor typo, otherwise looks good!
Co-authored-by: Mikaël Mayer <MikaelMayer@users.noreply.github.com>
davidcok
requested changes
Feb 18, 2023
alex-chew
changed the title
robin-aws
previously approved these changes
Apr 19, 2023
Member
robin-aws
left a comment
robin-aws
left a comment
There was a problem hiding this comment.
LGTM, made some non-blocking suggestions (because we have the opportunity to improve naming before this code is more locked down)
Member
|
See also: #119. I don't want to block on adding this under |
Contributor
Author
I'll take care of syncing to |
robin-aws
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a common use case where one wants to map an injective function over the keys of the map, retaining the values.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.