Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions __tests__/feeds.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1073,19 +1073,13 @@ describe('query feed', () => {
expect(res.data.feed.edges.length).toEqual(1);
});

it('should return feed v2 with TIME ranking', async () => {
it('should return feed v2 with TIME ranking using chronological config', async () => {
loggedUser = '1';
nock('http://localhost:6002')
.post('/config')
.reply(200, {
user_id: '1',
config: {
providers: {},
},
});
nock('http://localhost:6000')
.post('/feed.json', (body) => {
expect(body.feed_config_name).toBe('custom_feed_na_v1');
expect(body.order_by).toBe(FeedOrderBy.Date);
expect(body.disable_engagement_filter).toBe(true);
return true;
})
.reply(200, {
Expand Down
32 changes: 32 additions & 0 deletions __tests__/integrations/feed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import {
FeedConfigName,
FeedPreferencesConfigGenerator,
FeedResponse,
versionToTimeFeedGenerator,
} from '../../src/integrations/feed';
import { FeedOrderBy } from '../../src/entity/Feed';
import {
connectionFromNodes,
feedCursorPageGenerator,
Expand Down Expand Up @@ -893,3 +895,33 @@ describe('FeedLofnConfigGenerator', () => {
});
});
});

describe('versionToTimeFeedGenerator', () => {
beforeEach(async () => {
await saveFixtures(con, Source, sourcesFixture);
await con.getRepository(Feed).save({ id: '1', userId: '1' });
});

it('should generate config with chronological settings and no lofn', async () => {
let capturedBody: Record<string, unknown> = {};
nock('http://localhost:6000')
.post('/feed.json', (body) => {
capturedBody = body;
return true;
})
.reply(200, {
data: [{ post_id: '1' }],
});

const generator = versionToTimeFeedGenerator(20);
await generator.generate(ctx, {
user_id: '1',
page_size: 10,
offset: 0,
});

expect(capturedBody.feed_config_name).toBe(FeedConfigName.CustomFeedNaV1);
expect(capturedBody.order_by).toBe(FeedOrderBy.Date);
expect(capturedBody.disable_engagement_filter).toBe(true);
});
});
14 changes: 8 additions & 6 deletions src/integrations/feed/generators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,16 +172,18 @@ export const versionToFeedGenerator = (version: number): FeedGenerator => {
);
};

export const versionToTimeFeedGenerator = (version: number): FeedGenerator => {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
export const versionToTimeFeedGenerator = (_version: number): FeedGenerator => {
return new FeedGenerator(
feedClient,
new FeedLofnConfigGenerator(
{ ...baseFeedConfig, order_by: FeedOrderBy.Date },
lofnClient,
new FeedPreferencesConfigGenerator(
{
...opts,
feed_version: version.toString() as FeedVersion,
...baseFeedConfig,
feed_config_name: FeedConfigName.CustomFeedNaV1,
order_by: FeedOrderBy.Date,
disable_engagement_filter: true,
},
opts,
),
);
};
Loading