Include top level type declarations in java-imports-scan-file#22
Open
thejk wants to merge 2 commits intodakrone:masterfrom
Open
Include top level type declarations in java-imports-scan-file#22thejk wants to merge 2 commits intodakrone:masterfrom
thejk wants to merge 2 commits intodakrone:masterfrom
Conversation
In preparation for expanding the functionality, quite a bit of setup needed but it seems to work.
Add new function java-imports-list-top-level and use it in java-imports-scan-file to add public top level types to list of classes to add to cache. Useful when adding new types or working with a new project, save having to specify the package on first import. Only works if java-imports-scan-file runs after type is declared in file so for new files it might be worth adding (java-imports-scan-file) to define-auto-insert for example. No kotlin-mode support yet, haven't figured out a good way to do a "negative" match as "public" modifier is the default in kotlin. Also the primary constructor syntax is tricky to include and the regex is already rather horrible.
thejk
force-pushed
the
include_toplevel_in_scan
branch
from
b9a0105 to
7f9489f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new function java-imports-list-top-level and use it in java-imports-scan-file to add public top level types to list of classes to add to cache.
I find it useful when creating a new type or when opening a project for the first time to automatically get top level types added to the cache instead of having to import it at least once first.
Only works if java-imports-scan-file runs after type is declared in file so for new files it might be worth adding (java-imports-scan-file) to define-auto-insert for example.
No kotlin-mode support yet, haven't figured out a good way to do a "negative" match as "public" modifier is the default in kotlin. Also the primary constructor syntax is tricky to include and the regex is already rather horrible.