Implement turning off text rules with code comments#316
Open
skjdbg wants to merge 1 commit intodalance:masterfrom
Open
Implement turning off text rules with code comments#316skjdbg wants to merge 1 commit intodalance:masterfrom
skjdbg wants to merge 1 commit intodalance:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the feature to locally turn on/off rules with comments doesn't work with textrules.
As there does not seem to be a particular reason, I decided to implement it.
One detail on which I'd like a second opinion:
When receiving a
StartOfFileevent, I re-enable all text rules that were disabled.Since text rules are more file based, I thought it would be a mistake to have a disable propagate from one file to the next.
However, If someone has a use for it, removing this safety net does not impact other use cases.