Add packed_table to CudfVector#17
Draft
dan13bauer wants to merge 2 commits into
Draft
Conversation
When CudfVector is constructed from a packed_table, calling release()
materializes a new table from the view, which copies all data. This
change refactors callers to use getTableView() instead, keeping the
CudfVector alive during operations to avoid unnecessary copies.
Changes:
- CudfConversion: Use getTableView() in passthrough mode
- CudfHashAggregation: Change doGroupByAggregation, doGlobalAggregation,
and getDistinctKeys to accept table_view instead of unique_ptr<table>
- CudfHashJoin: Change all join functions (innerJoin, leftJoin, rightJoin,
leftSemiFilterJoin, rightSemiFilterJoin, antiJoin) to accept table_view
dan13bauer
pushed a commit
that referenced
this pull request
Mar 6, 2026
The old code checked handshakePtr != nullptr after reinterpret_cast, which is meaningless (reinterpret_cast of a non-null pointer never returns null). The real risk is the buffer being too small for the cast, which would cause reading past buffer bounds. Add null check on buffer itself, and validate buffer->getSize() >= sizeof(HandshakeMsg) BEFORE the reinterpret_cast. Remove the old meaningless null check after the cast. Review: @pentschev comment #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first shot at adding a
cudf::packed_tableto CudfVector and replacing some of the invocations ofcudfVector->release()withcudfVector->getTableView().