Revert "Demand prior releases of h5py for OSX on non-arm" #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cd5fbb0. This reverts the constraint added in cd5fbb0 which restricted h5py to versions <3.15 on Intel macOS based on the assumption that "no whls [were] built any longer". However, h5py 3.15.0 (released Oct 13, 2025) and 3.15.1 (released Oct 16, 2025) both include pre-built wheels for Intel macOS (x86_64) for all supported Python versions (3.10-3.14). The overly restrictive constraint caused CI test failures starting Jan 19, 2026 when the macos-15-intel GitHub Actions runner image was updated (version 20260120.0127.1). The same commit (ccdb659) passed on Jan 18 but failed on Jan 19, indicating an environmental incompatibility with the old h5py versions on the new runner. Fixes failing CI build #21127100740 (macos-15-intel CI failures) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1780 +/- ##
==========================================
- Coverage 75.11% 75.08% -0.03%
==========================================
Files 84 84
Lines 11921 11921
==========================================
- Hits 8954 8951 -3
- Misses 2967 2970 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yarikoptic
commented
Jan 30, 2026
Member
Author
yarikoptic
left a comment
yarikoptic
left a comment
There was a problem hiding this comment.
as far as installation of h5py goes on macs -- all good there.
@CodyCBakerPhD please review and approve/merge if all looking good for you -- I can't do myself since I am the author
Member
Author
|
Let's just do the which combines this too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cd5fbb0.
This reverts the constraint added in cd5fbb0 which restricted h5py to versions <3.15 on Intel macOS based on the assumption that "no whls [were] built any longer".
However, h5py 3.15.0 (released Oct 13, 2025) and 3.15.1 (released Oct 16, 2025) both include pre-built wheels for Intel macOS (x86_64) for all supported Python versions (3.10-3.14).
The overly restrictive constraint caused CI test failures starting Jan 19, 2026 when the macos-15-intel GitHub Actions runner image was updated (version 20260120.0127.1). The same commit (ccdb659) passed on Jan 18 but failed on Jan 19, indicating an environmental incompatibility with the old h5py versions on the new runner.
Fixes failing CI build #21127100740 (macos-15-intel CI failures)