#399 #416 Initial fix for header/footer showing on page without body rows#418
#399 #416 Initial fix for header/footer showing on page without body rows#418danfickle wants to merge 6 commits intoopen-dev-v1from
Conversation
…y rows. With test proof.
+ Remove unneeded casts. + Add override annotations. + Change anonymous class creation to lambda (manual).
Plus orphaned thead. Also compiler fixes for ContentLimit/ContentLimitContainer. Test based on the one provided by @jesselong. Thanks.
|
The test I just committed for #202 still produces this:
so clearly there is still more related problems in the table code. |
|
Right now it works differently. It puts part of text on the previous page, and part of it on the next, even that I have: in the styles. |
Need more testing before we can merge this branch. Specifically: Cells with margin/border/padding. Cells which go over two or more pages.
Partial revert of dce1cd5 to get paged table with cells with large padding/border rendering correctly. Unfortunately, this means that the #202 test with explicitly allowing page breaks in thead now fails again. Fortunately, very few users want a page break in their thead so this is low priority to fix.
|
@danfickle Hi, any update when this will be ready to be released? I'm hopeful it will fix the issues i'm experiencing. |
|
@VictorAtPL, it is not clear from your comment if this is a problem introduced in this pr or was already existing? If it was already existing I propose to merge this pr and do a release, then we can work more on table rendering in a different pr. @leedsalex Very soon if this pr has not introduced any additional problems as above. |
|
@danfickle |
|
Hi @VictorAtPL, |
3 participants
I also plan to add some commits to this PR with general table cleanup of code.
@VictorAtPL, if you get time, you could perhaps test this branch with your real world tables.