Fix pkg-config call to get vpnservicedir#139
Open
mbiebl wants to merge 1 commit intodanfruehauf:masterfrom
Open
Fix pkg-config call to get vpnservicedir#139mbiebl wants to merge 1 commit intodanfruehauf:masterfrom
mbiebl wants to merge 1 commit intodanfruehauf:masterfrom
Conversation
Calling $PKG_CONFIG with pkg-config as its first parameter will lead to a failure to resolve the vpnservicedir variable with newer versions of pkgconf.
Author
|
It seems like this was c&p error. Related downstream bug reports: |
Owner
|
@mbiebl Hoping to look at that very soon. Thank you for your contribution 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
$PKG_CONFIGwith pkg-config as its first parameter will lead to a failure to resolve the vpnservicedir variable with newer versions of pkgconf.