Skip to content

Fix arguments for danger-js to avoid discarding URL which contains danger-swift #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
417-72KI merged 2 commits into from
Sep 29, 2025
Merged

Fix arguments for danger-js to avoid discarding URL which contains danger-swift #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db7e72c
Fix arguments for danger-js to avoid discarding URL which contains `d…
417-72KI Sep 28, 2025
1222a49
update CHANGELOG
417-72KI Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@

## Master

- Fix arguments for danger-js to avoid discarding URL which contains `danger-swift` [@417-72KI][] - [#656](https://github.com/danger/swift/pull/656)

## 3.22.0

- Add `.xctestplan` extension to available file extensions [@gsl-anthonymerle][] - [#653](https://github.com/danger/swift/pull/653)
Expand Down
2 changes: 1 addition & 1 deletion Sources/Runner/Commands/RunDangerJS.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func runDangerJSCommandToRunDangerSwift(_ command: DangerCommand, logger: Logger
return nil
}

if arg.contains("danger-swift") || arg == command.rawValue {
if arg.hasSuffix("danger-swift") || arg == command.rawValue {
return nil
}

Expand Down