Web script improvements #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldop
reviewed
Feb 8, 2021
Comment on lines
11
to
19
| # Check for Homebrew, | ||
| # Install if we don't have it | ||
| if test ! $(which brew); then | ||
| echo "Installing homebrew..." | ||
| ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)" | ||
| fi | ||
| # Download and install nvm - Node version manager | ||
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.37.2/install.sh | bash | ||
|
|
||
| # Make sure we’re using the latest Homebrew. | ||
| brew update |
Owner
There was a problem hiding this comment.
This is needed in all scripts. Why did we remove it?
Owner
There was a problem hiding this comment.
Shouldn't we install nvm from brew?
Author
There was a problem hiding this comment.
I didn't check for nvm formulae for homebrew in the first place. There is one, so I'll use brew and revert homebrew check.
This reverts commit f174704.
danieldop
reviewed
Feb 11, 2021
web.sh
Outdated
|
|
||
| # Install and use lts Node release | ||
| nvm install --lts | ||
| brew install node@8 |
Owner
There was a problem hiding this comment.
can't we install nvm through brew?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefing
web.shscript was not working and outdated.Changes
Nodeinstallation.npmpackages installation.nvminstallation.Node.