Upgrade packages to minimize the size of dependency graph #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi@danielgerlag, I found an issue in the Conductor.Domain.csproj:
Packages Microsoft.Extensions.DependencyInjection.Abstractions v3.1.0, Microsoft.Extensions.Logging.Abstractions v3.1.0, SharpYaml v1.6.5, StackExchange.Redis v2.0.601 and WorkflowCore v3.2.2 transitively introduce 90 dependencies into conductor’s dependency graph (see dependency graph before upgrades), while Microsoft.Extensions.DependencyInjection.Abstractions v3.1.13, Microsoft.Extensions.Logging.Abstractions v3.1.13, SharpYaml v1.6.6, StackExchange.Redis v2.1.0 and WorkflowCore v3.5.0 can only introduce 52 dependencies (see dependency graph after upgrades).
These upgrades can help project minimize the size of dependency graph.
Hope the PR can help you.
Best regards,
sucrose