Some quality-of-life improvements#4
Open
TacoTheDank wants to merge 10 commits intodanielgjackson:masterfrom
Open
Some quality-of-life improvements#4TacoTheDank wants to merge 10 commits intodanielgjackson:masterfrom
TacoTheDank wants to merge 10 commits intodanielgjackson:masterfrom
Conversation
Owner
|
Hi @TacoTheDank, thanks for all this work -- somehow, I've only just noticed the pull request! I should get round to looking at it properly soon. Cheers. |
Author
|
@danielgjackson It's been a while. Any updates? |
|
@danielgjackson ??? |
|
@TacoTheDank Would you be willing to publish your fork on F-Droid? I really need this app but it barely works on my Pixel 7 Pro. |
|
@TacoTheDank can you merge to your own master branch (without deleting your patch branch, of course) and build the apk? Or, as @BenjaminBrienen said, publish your fork to F-Droid? Giving proper attribution, as is only right. |
|
@danielgjackson are you good with merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st commit
2nd commit
3rd commit
4th commit
5th commit
parseAsHtmlKTX extension (does version code check internally)ContextCompat.startForegroundService(does check internally)app:iconSpaceReserved="false"(fixes large padding on left side of preferences, makes them look nicer)6th commit
ic_notificationtoic_surround_sound, as this is the proper name for this drawable7th commit
8th commit
9th commit
10th commit
Feel free to ask any questions you might have.