Add type option, add a REDIS_KEY env variable#1
Open
warwickp wants to merge 4 commits intodanryan:masterfrom
Open
Add type option, add a REDIS_KEY env variable#1warwickp wants to merge 4 commits intodanryan:masterfrom
warwickp wants to merge 4 commits intodanryan:masterfrom
Conversation
Owner
|
Nice, thanks for the updates! I'll review these and merge 'em up. Cheers :) |
Owner
|
I still need to refactor woodchuck use logstash's own plugins, so this type option will actually be used quite a bit :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Dan
Woodchuck is great, thanks. I don't expect you will merge this, but I wanted to get your feedback anyway. Sounds like you have a configuration feature on the horizon.
This allows passing a 'type' option but doesn't make complete sense as is because type should be per path not global.
Also adds the ability to use a REDIS_KEY so you can define something other than 'namespace:events'.
I'm using this with multiple woodchucks running, 1 per type.
Also: no tests because I couldn't get the existing tests to pass anyway + laziness.