DAOS-18922: Unit test improvements for DAOS placement algorithm#18426
Draft
Siddarth-Raj wants to merge 1 commit into
Draft
DAOS-18922: Unit test improvements for DAOS placement algorithm#18426Siddarth-Raj wants to merge 1 commit into
Siddarth-Raj wants to merge 1 commit into
Conversation
|
Errors are component not formatted correctly,Ticket number suffix is not a number. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data |
Siddarth-Raj
force-pushed
the
daos_pl_ut_enh
branch
2 times, most recently
from
784a6a2 to
64debc4
Compare
Siddarth-Raj
requested review from
ashokdevaraj-09,
sneha-hpe and
vijaya-sindhoori-kaza
nssrikanth
reviewed
Jun 17, 2026
nssrikanth
reviewed
Jun 17, 2026
|
@Siddarth-Raj, Could you please add me as a reviewer? Thanks. |
Siddarth-Raj
force-pushed
the
daos_pl_ut_enh
branch
from
64debc4 to
b5fe872
Compare
Siddarth-Raj
force-pushed
the
daos_pl_ut_enh
branch
2 times, most recently
from
2c084e1 to
83a8a76
Compare
sneha-hpe
reviewed
Jun 24, 2026
Siddarth-Raj
force-pushed
the
daos_pl_ut_enh
branch
from
83a8a76 to
b769392
Compare
|
can we consider handling the return values in following function calls |
Siddarth-Raj
force-pushed
the
daos_pl_ut_enh
branch
from
b769392 to
6ed5400
Compare
Siddarth-Raj
force-pushed
the
daos_pl_ut_enh
branch
2 times, most recently
from
4485af7 to
5f009bd
Compare
Signed-off-by: Siddarth Raj <siddarth.raj@hpe.com>
Siddarth-Raj
force-pushed
the
daos_pl_ut_enh
branch
from
5f009bd to
dd653fb
Compare
| struct timespec _t0, _t1; | ||
|
|
||
| clock_gettime(CLOCK_MONOTONIC, &_t0); | ||
| rc = pl_obj_place(ctx->pl_map, PLT_LAYOUT_VERSION, &ctx->oids[i].oid, 0, NULL, |
There was a problem hiding this comment.
Every objects pool map version (omd_ver) is always sent as 1, because it's never updated.
| diff[i].nr = 0; | ||
| diff[i].shard_ids = NULL; | ||
| diff[i].spare_tgts = NULL; | ||
| md = ctx->oids[i].oid; |
There was a problem hiding this comment.
Here we can update the objects pool map version and pass it directly to pl_obj_find_rebuild instead of using a local variable(same as pl_obj_place).
ctx->oids[i].oid.omd_ver = ver;
| D_FREE(shard_ids); | ||
|
|
||
| /* Stage 2: advance targets to the final status */ | ||
| rc = ds_pool_map_tgts_update(NULL, ctx->pool_map, tgts, opc2, false, NULL, false); |
There was a problem hiding this comment.
The pool map version changes even when target status is changed from DOWN/DRAIN -> DOWNOUT, DOWNOUT -> UP. I suggest we update the objects pool map version in the capture_layouts before passing it to pl_obj_place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps for the author:
After all prior steps are complete: