DAOS-19006 control: Remove storage firmware update

[kjacque]

Firmware update for storage devices was supported for a very limited subset of devices, and has since become irrelevant in customer deployments. The feature is unused, so can be removed.

Features: control

Steps for the author:

• Commit message follows the guidelines.
• Appropriate Features or Test-tag pragmas were used.
• Appropriate Functional Test Stages were run.
• At least two positive code reviews including at least one code owner from each category referenced in the PR.
• Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

• Gatekeeper requested (daos-gatekeeper added as a reviewer).

[github-actions]

Ticket title is 'Remove firmware management functionality from DAOS'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-19006

[daosbuild3]

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18595/4/execution/node/1794/log

[tanabarr]

Items that probably also need to be removed:

• src/control/lib/spdk/nvme_stubs.go - Remove the Update() method (lines 27-30)
• src/control/lib/spdk/mocks.go - Remove the UpdateErr field

[kjacque]

Items that probably also need to be removed:

• src/control/lib/spdk/nvme_stubs.go - Remove the Update() method (lines 27-30)
• src/control/lib/spdk/mocks.go - Remove the UpdateErr field

Good catch, thanks.

[mjmac]

Looks great. Good to get rid of cruft. It seems like you could probably go further with the ipmctl stuff, if you wanted to do it all as one commit. As far as I can tell, control/lib/ipmctl is pretty much all dead code now, as the only caller was the firmware management stuff. The provisioning is still done by shelling out to the ipmctl binary.

The other thing that came up in my review is that you probably need to add a Obsoletes: daos-firmware in the main section specfile so that any systems that somehow installed the firmware RPM can do a clean upgrade. Won't be the end of the world if you don't. They'll need to manually remove the daos-firmware RPM before upgrading.

[kjacque]

It seems like you could probably go further with the ipmctl stuff, if you wanted to do it all as one commit. As far as I can tell, control/lib/ipmctl is pretty much all dead code now, as the only caller was the firmware management stuff. The provisioning is still done by shelling out to the ipmctl binary.

The other thing that came up in my review is that you probably need to add a Obsoletes: daos-firmware in the main section specfile so that any systems that somehow installed the firmware RPM can do a clean upgrade. Won't be the end of the world if you don't. They'll need to manually remove the daos-firmware RPM before upgrading.

Good catches. I'll update both of these. There's an ipmctl type still in use by some of the SCM logic, but I'll just move that where it's used.

[daosbuild3]

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18595/6/execution/node/1350/log

[tanabarr]

Good clean up but I would make sure we aren't introducing any SCM regressions by doing some manual testing with daos_server scm ... and dmg storage scan -v commands. I can't remember off the top of my head whether dmg storage query usage uses this indirectly as well so might be worth also verifying that.