[WIP] Signal Scheme Alchemy Integration#1504
[WIP] Signal Scheme Alchemy Integration#1504mrrobot16 wants to merge 44 commits intodaostack:devfrom
Conversation
release 20200302
release_20200303
* open proposal in new tab with ctrl-click * typo * handle mac command key
Share common modal styles across all modals. All ModalPopups can be closed by pressing esc or clicking on the background All modals have a header, body and optional footer
Also move all scheme utilities into a new lib/schemeUtils.ts file
|
@mrrobot16 travis fail |
tibetsprague
left a comment
tibetsprague
left a comment
There was a problem hiding this comment.
would love to get an overview of how close this is to ready and what is needed to do still?
src/components/Dao/DaoHeader.tsx
Outdated
| daoImg: "/assets/images/generic-user-avatar.png", | ||
| reputationHolders: memberCount, | ||
| holdings: [ | ||
| { name: "GEN", amount: 0.24653 }, |
There was a problem hiding this comment.
where are these numbers coming from?
There was a problem hiding this comment.
Sorry super late response. I had to take time off due to personal issues. I am back now.
What I am currently working on is on making it responsive and render "dao members count" and "dao holdings".
Another todo is when we have a signal scheme proposal we want to be able to show in the proposal summary what off chain data are we modifying so that users know what to expect to change if a signal scheme proposal is passed.
mrrobot16
changed the title
|
@mrrobot16 Can you please fill in the PR description to describe clearly and precisely what is the intent of this PR? Also be sure the title is consistent with the description. Thanks! If this is really limited to adding a DAOHeader, be clear about that. If it provides more general support for Signal, would like to know. :-) Also, how and why are you using GenericScheme? |
@dkent600 Thanks for taking time to look into this :) I have added a description at the beginning of this PR #1504 (comment) There you will find a spec document https://hackmd.io/Uf_6V3JTQRuu_Vc1EsJhsg and a mockup of what we want to display in the UI. To anwser your question as far as why we are using GenericScheme. I would not be able to answer since those decisions where not made by me and unfortunately the developer who was working on that part is no longer working on it :/ The backend part of this PR can be found here daostack/subgraph#494 |
mrrobot16
force-pushed
the
feat/signal-scheme
branch
from
1680310 to
33bb933
Compare
|
Fix there where many conflicts and the Alchemy has changed since this PR was created I have moved this PR #1758 |
6 participants
The purpose of this PR is to have enable to DAO's to have off chain data that can be changed/modified thru proposals.
PR Specs can be viewed here https://hackmd.io/Uf_6V3JTQRuu_Vc1EsJhsg
This PR is try to make this mock up happen:
