docs: document UriUtils.encodePath for Java client service invocation#5231
Open
javier-aliaga wants to merge 3 commits into
Open
docs: document UriUtils.encodePath for Java client service invocation#5231javier-aliaga wants to merge 3 commits into
javier-aliaga wants to merge 3 commits into
Conversation
newRequestBuilder no longer encodes the path; document that callers must encode segments containing URI-illegal characters (e.g. spaces) with UriUtils.encodePath, and that passing them raw throws IllegalArgumentException. Reflects dapr/java-sdk#1774. Signed-off-by: Javier Aliaga <javier@diagrid.io>
github-actions
Bot
added
the
automerge: java
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alicejgibbons
suggested changes
Jul 2, 2026
alicejgibbons
left a comment
alicejgibbons
left a comment
Contributor
There was a problem hiding this comment.
a few minor things
Drop the alert wrapper in favor of a plain paragraph, reword per review, and group the URL path encoding row with the user-responsibility rows. Signed-off-by: Javier Aliaga <javier@diagrid.io>
Contributor
|
Do we need backport for this and the other sdk doc with the comparison table in it for 1.17 SDK? |
Contributor
Author
|
@alicejgibbons we could, but also in 1.17 the invoke methods are not deprecated so maybe the table is not a 100% backport as it may mention a deprecation that has not happen for that version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newRequestBuilder no longer encodes the path; document that callers must encode segments containing URI-illegal characters (e.g. spaces) with UriUtils.encodePath, and that passing them raw throws IllegalArgumentException. Reflects dapr/java-sdk#1774.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Issue reference