Skip to content

Fix codecov#1135

Merged
sicoyle merged 3 commits into
dapr:mainfrom
acroca:codecov-fix
Jul 10, 2026
Merged

Fix codecov#1135
sicoyle merged 3 commits into
dapr:mainfrom
acroca:codecov-fix

Conversation

@acroca

@acroca acroca commented Jul 9, 2026

Copy link
Copy Markdown
Member

Codecov has been failing silently for a while now, that's why all PRs get the red check, see: https://github.com/dapr/python-sdk/actions/runs/28903767566/job/85746334110

error - 2026-07-07 22:44:33,769 -- Upload queued for processing failed: {"message":"Token required because branch is protected"}

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.12%. Comparing base (bffb749) to head (9005ef2).
⚠️ Report is 185 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1135      +/-   ##
==========================================
- Coverage   86.63%   82.12%   -4.51%     
==========================================
  Files          84      117      +33     
  Lines        4473     9537    +5064     
==========================================
+ Hits         3875     7832    +3957     
- Misses        598     1705    +1107     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make Codecov reporting reliable again for the Dapr Python SDK by (1) configuring coverage collection so unimported files don’t artificially inflate totals and (2) fixing Codecov authentication on protected branches using GitHub OIDC.

Changes:

  • Add coverage.py configuration (source, omit) in pyproject.toml to scope measured files to the SDK packages and exclude generated proto stubs.
  • Grant id-token: write and enable Codecov OIDC uploads in the main CI workflow, failing CI on push if the upload fails to avoid a stale base report.
  • Enable Codecov OIDC uploads in the tag/release workflow without blocking releases on Codecov outages.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Adds coverage.py runtime configuration to control source/omit behavior for CI coverage reporting.
.github/workflows/build.yaml Enables Codecov OIDC authentication and makes main-branch coverage upload failures visible.
.github/workflows/build-tag.yaml Enables Codecov OIDC authentication for tag builds without making releases depend on Codecov availability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml Outdated
Comment thread .github/workflows/build.yaml
Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca marked this pull request as ready for review July 9, 2026 07:25
@acroca acroca requested review from a team as code owners July 9, 2026 07:25

@sicoyle sicoyle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!!

@sicoyle sicoyle added this pull request to the merge queue Jul 10, 2026
Merged via the queue into dapr:main with commit 0210ccb Jul 10, 2026
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants