Skip to content

Conversation

@CasperGN
Copy link
Contributor

@CasperGN CasperGN commented Nov 22, 2025

Description

Extending dapr-ext-langgraph to expand on the handling for put, put_writes and get_tuple to conform with the native LangGraph RedisSaver. This ensures that the demo's presented in the LangGraph Academy are functional.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…or consistincy

Signed-off-by: Casper Nielsen <casper@diagrid.io>
…port

Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
…ites

Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
@CasperGN CasperGN force-pushed the feat/ext-langgraph-checkpoint branch from fab03ca to 7869a64 Compare November 22, 2025 02:42
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
@CasperGN CasperGN marked this pull request as ready for review November 23, 2025 05:33
@CasperGN CasperGN requested review from a team as code owners November 23, 2025 05:33
Signed-off-by: Casper Nielsen <casper@diagrid.io>
@acroca
Copy link
Member

acroca commented Nov 24, 2025

@CasperGN Please have a look at other examples in the examples directory and follow the same pattern. Specially the following:

  • The examples are runnable using mechanical markdown, you'll see the commands in the README.md. We run those files in our CI.
  • You should only need requirements.txt, the python files, the components and the readme. Check for example the workflow and the demo_workflow examples as a reference.
  • Hook your example in the CI, you'll find the list in the tox.ini

Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
@CasperGN
Copy link
Contributor Author

@acroca I've done the above and verified it runs locally with the validate.sh script.
This does however need the environment variable OPENAI_API_KEY to be present in order to run the example - how do we go about adding that?

Signed-off-by: Casper Nielsen <casper@diagrid.io>
@CasperGN
Copy link
Contributor Author

@acroca can you try to trigger CI to see if pulling a small llama model to be used for tests is too slow?

Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 70.55556% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.04%. Comparing base (bffb749) to head (45262f5).
⚠️ Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
...-langgraph/dapr/ext/langgraph/dapr_checkpointer.py 64.90% 53 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   86.63%   87.04%   +0.41%     
==========================================
  Files          84      100      +16     
  Lines        4473     6629    +2156     
==========================================
+ Hits         3875     5770    +1895     
- Misses        598      859     +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
…Add sleep to ensure ollama us serving before pulling model

Signed-off-by: Casper Nielsen <casper@diagrid.io>
Signed-off-by: Casper Nielsen <casper@diagrid.io>
@CasperGN
Copy link
Contributor Author

@acroca do you want me to add the conditional run for the ext packages and ollama in this PR or should I rather add this in a follow up?

I'll also need to do a follow up to implement the delete function similar to the changes in this one

@acroca
Copy link
Member

acroca commented Dec 16, 2025

@acroca do you want me to add the conditional run for the ext packages and ollama in this PR or should I rather add this in a follow up?

I'll also need to do a follow up to implement the delete function similar to the changes in this one

This PR adds roughly 2.5min to the CI build, right? I think it'd be good to split in a different runs, but I also want to experiment with running each validation in a different step to run.
Maybe let's merge as is, and we can improve CI runs in a separate PR.

@acroca acroca added this pull request to the merge queue Dec 16, 2025
Merged via the queue into dapr:main with commit 1645e1c Dec 16, 2025
12 of 13 checks passed
@CasperGN
Copy link
Contributor Author

CasperGN commented Dec 16, 2025

@acroca do you want me to add the conditional run for the ext packages and ollama in this PR or should I rather add this in a follow up?
I'll also need to do a follow up to implement the delete function similar to the changes in this one

This PR adds roughly 2.5min to the CI build, right? I think it'd be good to split in a different runs, but I also want to experiment with running each validation in a different step to run. Maybe let's merge as is, and we can improve CI runs in a separate PR.

Yeah and considering we'd be carrying more ext- packages in we should also have a conditional check on these so we don't have to pull ollama + llama3.2 every single time but only when the ext packages that needs it requires testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants