Skip to content

enable server-side decorations for KDE/Plasma with Wayland #19949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dtorop wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enable server-side decorations for KDE/Plasma with Wayland #19949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99524da
enable Wayland server-side decorations for KDE
dtorop Dec 19, 2025
dbbca35
gtk: use wayland protocol to detect if have SSD
dtorop Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 48 additions & 6 deletions src/gui/gtk.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
#include <gdk/gdkkeysyms.h>
#ifdef GDK_WINDOWING_WAYLAND
#include <gdk/gdkwayland.h>
#include <wayland-client.h>
#endif
#include <gtk/gtk.h>
#include <math.h>
Expand Down Expand Up @@ -1003,6 +1004,47 @@ dt_gui_session_type_t dt_gui_get_session_type(void)
#endif
}

#ifdef GDK_WINDOWING_WAYLAND
static gboolean _wayland_ssd_support;

static void _reg_global(void *data, struct wl_registry *reg,
uint32_t name, const char *iface, uint32_t version)
{
if (g_strcmp0(iface, "zxdg_decoration_manager_v1") == 0)
_wayland_ssd_support = TRUE;
}

static const struct wl_registry_listener reg_listener = {
.global = _reg_global,
// it is highly unlikely that decoration manager will disappear
.global_remove = NULL
};
#endif

// does display server suport windows with server-side decorations (SSD)?
static gboolean _check_ssd_support(void)
{
#ifdef GDK_WINDOWING_WAYLAND
// servers which support SSD (e.g. Plasma/KWin but not Gnome/Mutter)
// have xdg-decoration-unstable-v1 protocol in registery
if(dt_gui_get_session_type() == DT_GUI_SESSION_WAYLAND)
{
GdkDisplay* disp = gdk_display_get_default();
struct wl_display *wd = gdk_wayland_display_get_wl_display(disp);
struct wl_registry *reg = wl_display_get_registry(wd);
wl_registry_add_listener(reg, &reg_listener, NULL);
// receive the globals
wl_display_roundtrip(wd);
return _wayland_ssd_support;
}
else
#endif
{
// X11, MacOS, and Windows can handle SSD
return TRUE;
}
}

static gboolean _configure(GtkWidget *da,
GdkEventConfigure *event,
const gpointer user_data)
Expand Down Expand Up @@ -1745,24 +1787,24 @@ static void _init_widgets(dt_gui_gtk_t *gui)
gtk_widget_set_name(widget, "main_window");
gui->ui->main_window = widget;

#ifdef GDK_WINDOWING_WAYLAND
if(dt_gui_get_session_type() == DT_GUI_SESSION_WAYLAND)
if(!_check_ssd_support())
{
// On Wayland, use NORMAL hint to allow proper window resizing
gtk_window_set_type_hint(GTK_WINDOW(widget), GDK_WINDOW_TYPE_HINT_NORMAL);

// if must use client-side decoration (CSD), set up custom
// titlebar which allows for hiding that titlebar in maximized
// windows when using an extensions such as Unite
GtkWidget *header_bar = gtk_header_bar_new();
gtk_header_bar_set_title(GTK_HEADER_BAR(header_bar), "darktable");
gtk_header_bar_set_show_close_button(GTK_HEADER_BAR(header_bar), TRUE);
gtk_window_set_titlebar(GTK_WINDOW(widget), header_bar);
gtk_widget_show(header_bar);
}
#endif

dt_configure_ppd_dpi(gui);

gtk_window_set_default_size(GTK_WINDOW(widget),
DT_PIXEL_APPLY_DPI(900), DT_PIXEL_APPLY_DPI(500));
// allows for proper window resizing
gtk_window_set_type_hint(GTK_WINDOW(widget), GDK_WINDOW_TYPE_HINT_NORMAL);

gtk_window_set_icon_name(GTK_WINDOW(widget), "darktable");
gtk_window_set_title(GTK_WINDOW(widget), "darktable");
Expand Down