Skip to content

Point in-app help links to /development/ docs unconditionally #21418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andriiryzhkov wants to merge 1 commit into from
+2 −1
Closed

Point in-app help links to /development/ docs unconditionally #21418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/common/usermanual_url.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@ char *dt_get_manual_base_url()
// <lang> = en / fr ... (default = en)

// in case of a standard release, append the dt version to the url
if(dt_is_dev_version())

@TurboGit TurboGit Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we may fix that at some point I would advise to have:

if(TRUE && dt_is_dev_version())

And add a comment:

TODO: revert when documentation redirection is back....

@andriiryzhkov andriiryzhkov Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what is the point of redirection when we not planning per version documentation?

@TurboGit TurboGit Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand why you say that we are not planning per version documentation. This was the case and we are trying again to recover this. It will take time but hopefully this will be back at some point in the future. But maybe I miss some information about this?

@andriiryzhkov andriiryzhkov Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I came to this conclusion from

As of darktable 5.2 we no longer maintain separate versions of the user manual for each release of darktable, since we don’t have the resources to support this.

If there is a goal to return to versioned dtdocs, that's awesome. And in this case this fix does not make sense, and all we need now is to fix redirects on the site.

@andriiryzhkov andriiryzhkov Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meanwhile, updated per your comment to keep it as temporary solution.

@TurboGit TurboGit Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I was not aware of this end of versioning support :( So you may be right and so the code should be adjusted accordingly. Let me first discuss with the documentation team to take a final decision.

@TurboGit TurboGit Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andriiryzhkov : I have just discussed this with the documentation team and we will stop the versioned release after all. So let's go back to your first proposal and move forward.

I'm sorry for the confusion.

//TODO: drop the "TRUE ||" if dtdocs resumes per-release snapshots
if(TRUE || dt_is_dev_version())
{
dt_util_str_cat(&base_url, "development/");
}
Expand Down
Loading