Re-introduce previously reverted raster mask release fix - #21649
Merged
Conversation
Collaborator
Author
|
@TurboGit TIA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
5fad064in PR #21243 ("Fixes raster masks not being properly released") added_iop_prune_stale_raster_users()to pixelpipe_hb.c, which drops stale entries from a raster-mask source'sraster_mask.source.userstable. It decided whether a consumer was still "alive" using module-level state:sink->enabledandsink->blend_paramstrack the darkroom GUI and are not maintained in the export/CLI pipeline, which caused regression test 0167 to fail. Running with-d masks -d pipeshowed:bilatis enabled in history, butmodule->enabledwasFALSEin the export dev, so the prune wrongly dropped the live consumer and the raster mask vanished.Fix
In the export pipe the authoritative enabled/blendop state lives on the piece, not the module — pixelpipe_hb.h:53: "used to disable parts of the pipe for export, independent on module itself." So I passed
pipeinto the prune function and judged each consumer from its node inpipe->nodes:consumes = sink.source == module && piece->enabled && piece->blendop_data->mask_mode & DEVELOP_MASK_RASTER.Verification
expected.pngis pre-existing environmental noise (present on current passing master too).bilatand no "raster mask lost".userstables).Co-authored with Claude.