Fix AI model extraction on Windows profiles with non-ASCII paths - #21654
Merged
Conversation
andriiryzhkov
added
bugfix
TurboGit
added
scope: windows support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21640
Users with accented characters in their Windows profile (e.g.
C:\Users\Joël\...) can't install AI models. Extraction fails withFailed to open 'C:\Users\Joël\...'– UTF-8 bytes reinterpreted as CP1252.libarchive's narrow-char APIs go through the ANSI code page on Windows, as does the
_fullpathwe were using via arealpathshim. Route all pathname handoffs through the wide-char variants (archive_read_open_filename_w,archive_entry_copy_pathname_w,_wfullpath) with UTF-8 ↔ UTF-16 conversion via glib. POSIX unchanged. Old shim removed – it had the same bug this fixes.