added installation wiki file with more info and added screenshots#4
Open
VitorFrost wants to merge 8 commits intodarkxst:mainfrom
Open
added installation wiki file with more info and added screenshots#4VitorFrost wants to merge 8 commits intodarkxst:mainfrom
VitorFrost wants to merge 8 commits intodarkxst:mainfrom
Conversation
Create the translation for Brazilian Portuguese.
added a link to installation page
added screenshots to the readme
fix text
create detailed installation instruction wiki page
fix text
darkxst
reviewed
Dec 5, 2023
Owner
darkxst
left a comment
darkxst
left a comment
There was a problem hiding this comment.
Thanks for working in this, a couple of comments below
| wget "$download_url" | ||
| filename="${download_url##*/}" | ||
| tar -xf "$filename" | ||
| ``` |
Owner
There was a problem hiding this comment.
This is bit complex to drop on the end user, can you wrap it up in a shell script and put in root of repo.
This way the user could just copy and run a single command to install
wget <repo>/install.sh | sh install.sh
Maybe also just include the installation within the main README
Owner
There was a problem hiding this comment.
I'm happy to take translations, but please make that a seperate PR.
Author
There was a problem hiding this comment.
sorry, I started doing the translation and forgot about it! It wasn't my intention to include the translation yet!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added installation wiki file with more info and added screenshots