backport: bitcoin#24836, #25379, #25773, #25957, #25986, #26158, #26294, #26349, #26388, #26404, #26424, #26625, #27350

[knst]

What was done?

Regular backports from bitcoin core v25

How Has This Been Tested?

Run unit & functional tests

Breaking Changes

N/A

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone

[github-actions]

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

• backport: Merge bitcoin#28101, 28787, 27572, 28025 #7074 - backport: Merge bitcoin#28101, 28787, 27572, 28025

Please coordinate with the authors of these PRs to avoid merge conflicts.

[coderabbitai]

Walkthrough

This pull request introduces block filter-based wallet fast rescanning, a new submitpackage RPC command, and refactors build system header organization. Key changes include: migrating URL-related headers from util/url.h to common/url.h across multiple source files; adding benchmark::PriorityLevel::HIGH parameters to benchmark macro invocations in 40+ benchmark files; extending the Chain interface with two new methods for block filter index queries and matching; implementing fast rescan logic in wallet operations using block filters for descriptor wallets; introducing the experimental submitpackage RPC for regtest that accepts and processes transaction packages; adding a new SCAN log category; extending descriptor script key management with index filtering; and refactoring functional tests to use MiniWallet and adding comprehensive test coverage for fast rescan and package submission scenarios.

Sequence Diagram(s)

sequenceDiagram
    participant Node as Node/Wallet
    participant ChainImpl as ChainImpl
    participant FilterIdx as BlockFilterIndex
    participant Filter as GCSFilter

    Note over Node,Filter: Block Filter Matching Request
    Node->>ChainImpl: blockFilterMatchesAny(filter_type, block_hash, element_set)
    ChainImpl->>FilterIdx: GetBlockFilterIndex(filter_type)
    alt Index exists
        FilterIdx-->>ChainImpl: BlockFilterIndex instance
        ChainImpl->>ChainImpl: LookupFilter(block_hash)
        alt Filter found
            ChainImpl->>Filter: MatchAny(element_set)
            Filter-->>ChainImpl: bool (match result)
            ChainImpl-->>Node: std::optional<bool> (match result)
        else Filter not found
            ChainImpl-->>Node: std::nullopt
        end
    else Index not available
        FilterIdx-->>ChainImpl: nullptr
        ChainImpl-->>Node: std::nullopt
    end

Loading

sequenceDiagram
    participant Wallet as Wallet::Rescan
    participant BlockFilter as FastWalletRescanFilter
    participant ChainImpl as ChainImpl
    participant Node as Node/Block

    Note over Wallet,Node: Fast Rescan with Block Filters (Descriptor Wallet)
    Wallet->>BlockFilter: Create (from all DescriptorScriptPubKeyMans)
    BlockFilter-->>BlockFilter: Build GCS filter set
    
    loop For each block in range
        Wallet->>BlockFilter: UpdateIfNeeded() [detect descriptor top-ups]
        Wallet->>BlockFilter: MatchesBlock(block_hash)
        alt Filter indicates match
            BlockFilter-->>Wallet: true
            Wallet->>Node: Fetch and inspect block
            Node-->>Wallet: Block data & transactions
            Wallet->>Wallet: Process transactions
        else Filter indicates no match
            BlockFilter-->>Wallet: false
            Wallet->>Wallet: Skip block (update scan state only)
        else Filter cannot determine (nullopt)
            BlockFilter-->>Wallet: std::nullopt
            Wallet->>Wallet: Log warning, inspect block as fallback
        end
    end
    
    Wallet-->>Wallet: Rescan complete (fast or slow variant logged)

Loading

sequenceDiagram
    participant RPC as submitpackage RPC
    participant Mempool as Mempool
    participant Validation as Validation
    participant Net as Network

    Note over RPC,Net: submitpackage RPC Execution
    RPC->>RPC: Decode hex transactions array
    RPC->>Validation: Parse & validate each transaction
    
    loop For each transaction
        alt Valid
            Validation-->>RPC: Transaction object
        else Invalid
            Validation-->>RPC: Error (rejected)
            RPC->>RPC: Record failure with reason
        end
    end
    
    RPC->>Mempool: Process package through mempool
    alt Package policy valid
        Mempool->>Validation: Validate individual transactions
        loop For each tx in package
            alt Accepted
                Mempool-->>RPC: txid, size, fees
                Net->>Net: Broadcast transaction
            else Rejected
                Mempool-->>RPC: Failure reason
            end
        end
        RPC-->>RPC: Return per-tx results with package-feerate
    else Package policy invalid
        Mempool-->>RPC: Package error
        RPC-->>RPC: Return error response
    end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.89% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies this as a backport of multiple Bitcoin Core v25 PRs, which aligns with the extensive changes across benchmark framework, wallet rescan, RPC, tests, and CI configurations shown in the changeset.
Description check	✅ Passed	The description relates to the changeset by stating it contains backports from Bitcoin Core v25 with unit and functional tests run, matching the scope of changes present in the PR.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

Fix all issues with AI Agents 🤖

In @test/functional/mempool_packages.py:
- Around line 231-239: The comparison currently uses identity instead of
equality: replace the identity check `if utxo['txid'] is parent_transaction`
with an equality check against the txid string (i.e., compare utxo['txid'] ==
parent_transaction) so tx_children is populated reliably when the utxo txid
matches parent_transaction; update the condition in the loop that builds
chain/tx_children accordingly.

In @test/functional/rpc_packages.py:
- Around line 268-293: In test_submit_child_with_parents, replace uses of the
internal integer tx.hash with the hex txid string package_txn["txid"]: change
the loop membership check and lookup against submitpackage_result["tx-results"]
to use package_txn["txid"] (both the assert and tx_result assignment), and
change the peer.wait_for_broadcast call to pass a list of package_txn["txid"]
strings instead of tx["tx"].hash so wait_for_broadcast receives hex txid
strings.
- Around line 295-323: In test_submit_cpfp the child transaction is being
referenced by tx_child["tx"].hash and wait_for_broadcast is passed integer
hashes, which is inconsistent with the parent lookups (tx_rich/tx_poor using
"txid") and P2PTxInvStore API; change the child lookup to use
submitpackage_result["tx-results"][tx_child["txid"]] and pass txid strings to
peer.wait_for_broadcast by using [tx["txid"] for tx in package_txns] so all
indexing and broadcast checking consistently use txid strings (update references
to tx_child, package_txns, submitpackage_result, and peer.wait_for_broadcast
accordingly).

🧹 Nitpick comments (4)

test/functional/wallet_listsinceblock.py (1)

404-416: Consider using next() for safer list filtering.

The test logic correctly verifies that OP_RETURN outputs don't include an address field. However, the list comprehension with [0] indexing could raise IndexError if no matching transaction is found.

🔎 Safer alternative using next()

-        op_ret_tx = [tx for tx in self.nodes[2].listsinceblock(blockhash=block_hash)["transactions"] if tx['txid'] == tx_id][0]
+        op_ret_tx = next(tx for tx in self.nodes[2].listsinceblock(blockhash=block_hash)["transactions"] if tx['txid'] == tx_id)

This will raise StopIteration with a clearer error message if the transaction isn't found, or you can provide a default value:

op_ret_tx = next((tx for tx in self.nodes[2].listsinceblock(blockhash=block_hash)["transactions"] if tx['txid'] == tx_id), None)
assert op_ret_tx is not None, "Transaction not found"

test/functional/wallet_listtransactions.py (1)

170-179: Consider using next() for safer list filtering.

The test correctly verifies that OP_RETURN outputs don't include an address field in listtransactions. However, using [0] on the filtered list could raise IndexError if no matching transaction is found.

🔎 Safer alternative using next()

-        op_ret_tx = [tx for tx in self.nodes[0].listtransactions() if tx['txid'] == tx_id][0]
+        op_ret_tx = next(tx for tx in self.nodes[0].listtransactions() if tx['txid'] == tx_id)

This will raise StopIteration with a clearer error message if the transaction isn't found, or you can provide a default value with explicit error handling:

op_ret_tx = next((tx for tx in self.nodes[0].listtransactions() if tx['txid'] == tx_id), None)
assert op_ret_tx is not None, "Transaction not found in listtransactions"

test/functional/wallet_fast_rescan.py (2)

47-47: Replace print() with self.log.info() for consistency.

This appears to be leftover debug output. All other logging in this test uses self.log.info().

🔎 Proposed fix

-        print(w.importdescriptors([{"desc": descsum_create(f"wpkh({fixed_key.privkey})"), "timestamp": "now"}]))
+        self.log.info(w.importdescriptors([{"desc": descsum_create(f"wpkh({fixed_key.privkey})"), "timestamp": "now"}]))

---

52-52: Remove extraneous f-string prefix.

Static analysis correctly identifies this f-string has no placeholders. This is a minor style issue.

🔎 Proposed fix

-        self.log.info(f"Create txs sending to end range address of each descriptor, triggering top-ups")
+        self.log.info("Create txs sending to end range address of each descriptor, triggering top-ups")

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e376079 and b21e0a6.

📒 Files selected for processing (81)

• ci/dash/lint-tidy.sh
• ci/test/00_setup_env_mac_native_arm64.sh
• ci/test/04_install.sh
• doc/descriptors.md
• src/Makefile.am
• src/bench/addrman.cpp
• src/bench/base58.cpp
• src/bench/bech32.cpp
• src/bench/bench.h
• src/bench/bip324_ecdh.cpp
• src/bench/block_assemble.cpp
• src/bench/bls.cpp
• src/bench/bls_dkg.cpp
• src/bench/bls_pubkey_agg.cpp
• src/bench/ccoins_caching.cpp
• src/bench/chacha20.cpp
• src/bench/checkblock.cpp
• src/bench/checkqueue.cpp
• src/bench/coin_selection.cpp
• src/bench/crypto_hash.cpp
• src/bench/duplicate_inputs.cpp
• src/bench/ecdsa.cpp
• src/bench/ellswift.cpp
• src/bench/examples.cpp
• src/bench/gcs_filter.cpp
• src/bench/hashpadding.cpp
• src/bench/load_external.cpp
• src/bench/lockedpool.cpp
• src/bench/logging.cpp
• src/bench/mempool_eviction.cpp
• src/bench/mempool_stress.cpp
• src/bench/merkle_root.cpp
• src/bench/peer_eviction.cpp
• src/bench/poly1305.cpp
• src/bench/pool.cpp
• src/bench/pow_hash.cpp
• src/bench/prevector.cpp
• src/bench/rollingbloom.cpp
• src/bench/rpc_blockchain.cpp
• src/bench/rpc_mempool.cpp
• src/bench/strencodings.cpp
• src/bench/string_cast.cpp
• src/bench/util_time.cpp
• src/bench/verify_script.cpp
• src/bench/wallet_balance.cpp
• src/bench/wallet_create.cpp
• src/bench/wallet_loading.cpp
• src/bitcoin-cli.cpp
• src/bitcoin-wallet.cpp
• src/bitcoind.cpp
• src/common/url.cpp
• src/common/url.h
• src/interfaces/chain.h
• src/logging.cpp
• src/logging.h
• src/node/interfaces.cpp
• src/qt/main.cpp
• src/rpc/client.cpp
• src/rpc/mempool.cpp
• src/test/fuzz/rpc.cpp
• src/test/fuzz/string.cpp
• src/test/util/setup_common.cpp
• src/util/error.cpp
• src/util/error.h
• src/wallet/rpc/backup.cpp
• src/wallet/rpc/transactions.cpp
• src/wallet/rpc/util.cpp
• src/wallet/rpc/wallet.cpp
• src/wallet/scriptpubkeyman.cpp
• src/wallet/scriptpubkeyman.h
• src/wallet/wallet.cpp
• test/functional/mempool_package_limits.py
• test/functional/mempool_packages.py
• test/functional/rpc_getblockfrompeer.py
• test/functional/rpc_packages.py
• test/functional/test_framework/util.py
• test/functional/test_framework/wallet.py
• test/functional/test_runner.py
• test/functional/wallet_fast_rescan.py
• test/functional/wallet_listsinceblock.py
• test/functional/wallet_listtransactions.py

💤 Files with no reviewable changes (1)

• test/functional/test_framework/util.py

🧰 Additional context used

📓 Path-based instructions (8)

src/**/*.{cpp,h,hpp,cc}

📄 CodeRabbit inference engine (CLAUDE.md)

Dash Core implementation must be written in C++20, requiring at least Clang 16 or GCC 11.1

Files:

• src/wallet/rpc/util.cpp
• src/bench/strencodings.cpp
• src/bench/bip324_ecdh.cpp
• src/bench/coin_selection.cpp
• src/bench/hashpadding.cpp
• src/bench/mempool_stress.cpp
• src/bench/merkle_root.cpp
• src/bench/bls_pubkey_agg.cpp
• src/common/url.h
• src/wallet/scriptpubkeyman.h
• src/bench/pool.cpp
• src/bench/wallet_create.cpp
• src/bench/duplicate_inputs.cpp
• src/bench/rollingbloom.cpp
• src/wallet/rpc/backup.cpp
• src/util/error.cpp
• src/bench/gcs_filter.cpp
• src/bench/load_external.cpp
• src/bench/logging.cpp
• src/bench/checkqueue.cpp
• src/test/fuzz/rpc.cpp
• src/bench/addrman.cpp
• src/bench/rpc_blockchain.cpp
• src/util/error.h
• src/bench/checkblock.cpp
• src/bench/ecdsa.cpp
• src/bench/mempool_eviction.cpp
• src/bench/bench.h
• src/bench/ccoins_caching.cpp
• src/interfaces/chain.h
• src/bench/pow_hash.cpp
• src/bench/wallet_loading.cpp
• src/bench/examples.cpp
• src/bench/bls_dkg.cpp
• src/bench/chacha20.cpp
• src/bench/string_cast.cpp
• src/logging.h
• src/bench/base58.cpp
• src/wallet/rpc/wallet.cpp
• src/bench/bls.cpp
• src/bench/poly1305.cpp
• src/bench/util_time.cpp
• src/bitcoin-wallet.cpp
• src/bench/lockedpool.cpp
• src/wallet/wallet.cpp
• src/logging.cpp
• src/wallet/rpc/transactions.cpp
• src/bench/rpc_mempool.cpp
• src/bench/wallet_balance.cpp
• src/test/fuzz/string.cpp
• src/bitcoin-cli.cpp
• src/node/interfaces.cpp
• src/wallet/scriptpubkeyman.cpp
• src/bench/block_assemble.cpp
• src/bitcoind.cpp
• src/bench/ellswift.cpp
• src/rpc/client.cpp
• src/common/url.cpp
• src/bench/prevector.cpp
• src/bench/verify_script.cpp
• src/bench/crypto_hash.cpp
• src/bench/bech32.cpp
• src/bench/peer_eviction.cpp
• src/rpc/mempool.cpp
• src/qt/main.cpp
• src/test/util/setup_common.cpp

src/wallet/**/*.{cpp,h}

📄 CodeRabbit inference engine (CLAUDE.md)

Wallet implementation must use Berkeley DB and SQLite

Files:

• src/wallet/rpc/util.cpp
• src/wallet/scriptpubkeyman.h
• src/wallet/rpc/backup.cpp
• src/wallet/rpc/wallet.cpp
• src/wallet/wallet.cpp
• src/wallet/rpc/transactions.cpp
• src/wallet/scriptpubkeyman.cpp

src/bench/**/*.{cpp,h}

📄 CodeRabbit inference engine (CLAUDE.md)

Performance benchmarks in src/bench/ must use the nanobench library

Files:

• src/bench/strencodings.cpp
• src/bench/bip324_ecdh.cpp
• src/bench/coin_selection.cpp
• src/bench/hashpadding.cpp
• src/bench/mempool_stress.cpp
• src/bench/merkle_root.cpp
• src/bench/bls_pubkey_agg.cpp
• src/bench/pool.cpp
• src/bench/wallet_create.cpp
• src/bench/duplicate_inputs.cpp
• src/bench/rollingbloom.cpp
• src/bench/gcs_filter.cpp
• src/bench/load_external.cpp
• src/bench/logging.cpp
• src/bench/checkqueue.cpp
• src/bench/addrman.cpp
• src/bench/rpc_blockchain.cpp
• src/bench/checkblock.cpp
• src/bench/ecdsa.cpp
• src/bench/mempool_eviction.cpp
• src/bench/bench.h
• src/bench/ccoins_caching.cpp
• src/bench/pow_hash.cpp
• src/bench/wallet_loading.cpp
• src/bench/examples.cpp
• src/bench/bls_dkg.cpp
• src/bench/chacha20.cpp
• src/bench/string_cast.cpp
• src/bench/base58.cpp
• src/bench/bls.cpp
• src/bench/poly1305.cpp
• src/bench/util_time.cpp
• src/bench/lockedpool.cpp
• src/bench/rpc_mempool.cpp
• src/bench/wallet_balance.cpp
• src/bench/block_assemble.cpp
• src/bench/ellswift.cpp
• src/bench/prevector.cpp
• src/bench/verify_script.cpp
• src/bench/crypto_hash.cpp
• src/bench/bech32.cpp
• src/bench/peer_eviction.cpp

{guix-build*,releases,**/guix-build*,releases/**,.github/**,depends/**,ci/**,contrib/**,doc/**}

📄 CodeRabbit inference engine (CLAUDE.md)

Do not make changes to build system files (guix-build*), release artifacts, or avoid changes to .github, depends, ci, contrib, and doc directories unless specifically prompted

Files:

• ci/test/00_setup_env_mac_native_arm64.sh
• ci/test/04_install.sh
• doc/descriptors.md
• ci/dash/lint-tidy.sh

test/functional/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

Functional tests in test/functional/ must be written in Python (minimum version specified in .python-version) and depend on dashd and dash-node

Files:

• test/functional/wallet_listtransactions.py
• test/functional/mempool_packages.py
• test/functional/wallet_fast_rescan.py
• test/functional/test_framework/wallet.py
• test/functional/mempool_package_limits.py
• test/functional/rpc_getblockfrompeer.py
• test/functional/rpc_packages.py
• test/functional/wallet_listsinceblock.py
• test/functional/test_runner.py

src/{test,wallet/test}/**/*.{cpp,h}

📄 CodeRabbit inference engine (CLAUDE.md)

Unit tests in src/test/ and src/wallet/test/ must use Boost::Test framework

Files:

• src/test/fuzz/rpc.cpp
• src/test/fuzz/string.cpp
• src/test/util/setup_common.cpp

src/node/**/*.{cpp,h}

📄 CodeRabbit inference engine (CLAUDE.md)

NodeContext must be extended with Dash-specific managers for each subsystem during initialization

Files:

• src/node/interfaces.cpp

src/qt/**/*.{cpp,h}

📄 CodeRabbit inference engine (CLAUDE.md)

GUI implementation in src/qt/ must use Qt 5

Files:

• src/qt/main.cpp

🧠 Learnings (31)

📓 Common learnings

Learnt from: kwvg
Repo: dashpay/dash PR: 6543
File: src/wallet/receive.cpp:240-251
Timestamp: 2025-02-06T14:34:30.466Z
Learning: Pull request #6543 is focused on move-only changes and refactoring, specifically backporting from Bitcoin. Behavior changes should be proposed in separate PRs.

Learnt from: knst
Repo: dashpay/dash PR: 6916
File: src/univalue/include/univalue.h:81-88
Timestamp: 2025-10-25T07:08:51.918Z
Learning: For backport PRs from bitcoin/bitcoin, bitcoin-core/gui, etc., backported changes should match the original upstream PRs even if they appear strange, modify vendored code, or seem to violate coding guidelines. Still flag genuine issues like bugs, undefined behavior, crashes, compilation errors, or linter failures.

Learnt from: knst
Repo: dashpay/dash PR: 6883
File: src/rpc/rawtransaction.cpp:1088-1125
Timestamp: 2025-10-13T12:37:12.357Z
Learning: In backport pull requests (especially from Bitcoin Core), treat "moved" or refactored code as out-of-scope for content-level review. Focus validation on verifying that code is moved correctly: no fields added, no fields removed, no fields reordered, and no unexpected changes beyond whitespace adjustments. Pre-existing issues in the upstream code should be preserved to maintain fidelity to the original implementation.

Learnt from: knst
Repo: dashpay/dash PR: 6871
File: contrib/guix/libexec/build.sh:358-360
Timestamp: 2025-10-05T20:38:28.457Z
Learning: In the Dash repository, when backporting code from Bitcoin Core, typos and minor issues in comments should be kept as-is to reduce merge conflicts in future backports, even if they remain unfixed in Bitcoin Core's master branch.

Learnt from: UdjinM6
Repo: dashpay/dash PR: 6786
File: ci/test/04_install.sh:99-101
Timestamp: 2025-08-01T07:46:37.840Z
Learning: In backport PRs like #6786, UdjinM6 prefers to defer non-critical fixes (such as shell command expansion issues) to separate commits/PRs to maintain focus on the primary backport objectives, consistent with the project's pattern of avoiding scope creep.

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/{validation,txmempool}/**/*.{cpp,h} : Block validation and mempool handling must use extensions to Bitcoin Core mechanisms for special transaction validation and enhanced transaction relay

📚 Learning: 2025-08-08T07:01:47.332Z

Learnt from: knst
Repo: dashpay/dash PR: 6805
File: src/wallet/rpc/wallet.cpp:357-357
Timestamp: 2025-08-08T07:01:47.332Z
Learning: In src/wallet/rpc/wallet.cpp, the upgradetohd RPC now returns a UniValue string message (RPCResult::Type::STR) instead of a boolean, including guidance about mnemonic backup and null-character passphrase handling; functional tests have been updated to assert returned strings in several cases.

Applied to files:

• src/wallet/rpc/util.cpp
• src/bench/wallet_create.cpp
• src/wallet/rpc/backup.cpp
• src/bench/wallet_loading.cpp
• test/functional/mempool_packages.py
• src/wallet/rpc/wallet.cpp
• src/bitcoin-wallet.cpp
• src/wallet/rpc/transactions.cpp
• src/bitcoin-cli.cpp
• test/functional/rpc_packages.py
• src/rpc/client.cpp
• src/rpc/mempool.cpp

📚 Learning: 2025-10-25T07:08:51.918Z

Learnt from: knst
Repo: dashpay/dash PR: 6916
File: src/univalue/include/univalue.h:81-88
Timestamp: 2025-10-25T07:08:51.918Z
Learning: The univalue library (in src/univalue/) is no longer a vendored external dependency but is now part of the Bitcoin Core codebase and can be modified as needed during backports.

Applied to files:

• src/wallet/rpc/util.cpp
• src/common/url.h
• src/bitcoin-wallet.cpp
• src/bitcoind.cpp

📚 Learning: 2025-02-14T15:19:17.218Z

Learnt from: kwvg
Repo: dashpay/dash PR: 6529
File: src/wallet/rpcwallet.cpp:3002-3003
Timestamp: 2025-02-14T15:19:17.218Z
Learning: The `GetWallet()` function calls in `src/wallet/rpcwallet.cpp` are properly validated with null checks that throw appropriate RPC errors, making additional validation unnecessary.

Applied to files:

• src/wallet/rpc/util.cpp
• src/wallet/rpc/wallet.cpp
• src/wallet/rpc/transactions.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/wallet/**/*.{cpp,h} : Wallet implementation must use Berkeley DB and SQLite

Applied to files:

• src/wallet/rpc/util.cpp
• src/bench/wallet_create.cpp
• src/bench/wallet_loading.cpp
• src/wallet/rpc/wallet.cpp
• src/bitcoin-wallet.cpp
• src/wallet/wallet.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/bench/**/*.{cpp,h} : Performance benchmarks in src/bench/ must use the nanobench library

Applied to files:

• src/bench/strencodings.cpp
• src/bench/coin_selection.cpp
• src/bench/hashpadding.cpp
• src/bench/mempool_stress.cpp
• src/bench/bls_pubkey_agg.cpp
• src/bench/pool.cpp
• src/bench/rollingbloom.cpp
• src/bench/gcs_filter.cpp
• src/bench/load_external.cpp
• src/bench/logging.cpp
• src/bench/checkqueue.cpp
• src/bench/addrman.cpp
• src/bench/rpc_blockchain.cpp
• src/bench/checkblock.cpp
• src/bench/ecdsa.cpp
• src/bench/mempool_eviction.cpp
• src/bench/bench.h
• src/bench/ccoins_caching.cpp
• src/bench/pow_hash.cpp
• src/bench/wallet_loading.cpp
• src/bench/examples.cpp
• src/bench/bls_dkg.cpp
• src/bench/chacha20.cpp
• src/bench/string_cast.cpp
• src/bench/base58.cpp
• src/bench/poly1305.cpp
• src/bench/util_time.cpp
• src/bench/lockedpool.cpp
• src/bench/wallet_balance.cpp
• src/bench/block_assemble.cpp
• src/bench/prevector.cpp
• src/bench/verify_script.cpp
• src/bench/crypto_hash.cpp
• src/bench/bech32.cpp
• src/bench/peer_eviction.cpp

📚 Learning: 2025-01-02T08:33:26.751Z

Learnt from: kwvg
Repo: dashpay/dash PR: 6516
File: ci/test/00_setup_env_mac.sh:11-11
Timestamp: 2025-01-02T08:33:26.751Z
Learning: The removal of DMG support in the macOS packaging process eliminates the need for python-based scripts or python3-setuptools in the build environment. The PACKAGES variable in ci/test/00_setup_env_mac.sh is vestigial due to the use of a general-purpose Docker container defined in contrib/containers/ci/Dockerfile.

Applied to files:

• ci/test/00_setup_env_mac_native_arm64.sh
• ci/test/04_install.sh

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/coinjoin/**/*.{cpp,h} : CoinJoin implementation must use masternode-coordinated mixing sessions with uniform denomination outputs

Applied to files:

• src/bench/coin_selection.cpp
• src/wallet/wallet.cpp
• src/node/interfaces.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/{masternode,llmq}/**/*.{cpp,h} : BLS integration must be used for cryptographic foundation of advanced masternode features

Applied to files:

• src/bench/bls_pubkey_agg.cpp
• src/wallet/rpc/wallet.cpp
• src/bench/bls.cpp
• src/node/interfaces.cpp
• src/rpc/mempool.cpp
• src/test/util/setup_common.cpp

📚 Learning: 2025-12-22T15:42:48.595Z

Learnt from: kwvg
Repo: dashpay/dash PR: 7068
File: src/qt/guiutil_font.h:68-77
Timestamp: 2025-12-22T15:42:48.595Z
Learning: In C++/Qt codebases, use fail-fast asserts in setters to enforce invariants (e.g., ensuring internal maps contain necessary keys). Prefer assert() for programmer errors that should be caught in development and debugging, rather than defensive runtime checks with fallbacks. This helps catch invariant violations early during development. Apply to header and source files where invariant-driven state mutations occur, especially in setters like SetWeightBold/SetWeightNormal that assume established relationships or preconditions.

Applied to files:

• src/common/url.h
• src/wallet/scriptpubkeyman.h
• src/util/error.h
• src/bench/bench.h
• src/interfaces/chain.h
• src/logging.h

📚 Learning: 2025-12-17T13:58:26.891Z

Learnt from: kwvg
Repo: dashpay/dash PR: 7072
File: src/qt/walletcontroller.cpp:520-528
Timestamp: 2025-12-17T13:58:26.891Z
Learning: In Dash Qt wallet code, when leveraging upstream Bitcoin Core wallet capabilities (especially for operations like rescanning), prefer using the inherited signal-based mechanisms (e.g., ShowProgress signals) over adding explicit Qt progress dialogs to minimize upstream deviation and simplify future backports.

Applied to files:

• src/wallet/rpc/backup.cpp
• src/wallet/wallet.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/{validation,txmempool}/**/*.{cpp,h} : Block validation and mempool handling must use extensions to Bitcoin Core mechanisms for special transaction validation and enhanced transaction relay

Applied to files:

• src/bench/rpc_blockchain.cpp
• src/bench/checkblock.cpp
• src/Makefile.am
• src/interfaces/chain.h
• test/functional/mempool_packages.py
• src/wallet/rpc/wallet.cpp
• src/bitcoin-wallet.cpp
• src/wallet/wallet.cpp
• src/wallet/rpc/transactions.cpp
• src/bench/rpc_mempool.cpp
• src/bitcoin-cli.cpp
• src/node/interfaces.cpp
• ci/dash/lint-tidy.sh
• src/rpc/mempool.cpp

📚 Learning: 2025-09-02T07:34:28.226Z

Learnt from: knst
Repo: dashpay/dash PR: 6834
File: test/functional/wallet_mnemonicbits.py:50-51
Timestamp: 2025-09-02T07:34:28.226Z
Learning: CJ (CoinJoin) descriptors with derivation path "9'/1" are intentionally inactive in descriptor wallets, while regular internal/external descriptors with different derivation paths remain active.

Applied to files:

• doc/descriptors.md

📚 Learning: 2025-07-23T09:30:34.631Z

Learnt from: kwvg
Repo: dashpay/dash PR: 6761
File: src/chainlock/signing.h:5-6
Timestamp: 2025-07-23T09:30:34.631Z
Learning: Dash Core uses BITCOIN_ prefix for header guards as the standard convention, inherited from Bitcoin Core. Only a few BLS-specific files in src/bls/ use DASH_ prefix. The vast majority of files (385+) use BITCOIN_ prefix.

Applied to files:

• src/Makefile.am
• src/logging.h
• src/bench/crypto_hash.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Dash extends Bitcoin Core through composition with minimal changes to the Bitcoin Core foundation

Applied to files:

• src/Makefile.am

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/llmq/**/*.{cpp,h} : ChainLocks implementation must prevent reorganizations and provide block finality through 51% attack prevention

Applied to files:

• src/interfaces/chain.h
• src/rpc/mempool.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/{validation,consensus,net_processing}/**/*.{cpp,h} : ValidationInterface callbacks must be used for event-driven architecture to coordinate subsystems during block/transaction processing

Applied to files:

• src/interfaces/chain.h
• src/node/interfaces.cpp
• src/rpc/mempool.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/node/chainstate.{cpp,h} : Chainstate initialization must be separated into dedicated src/node/chainstate.* files

Applied to files:

• src/interfaces/chain.h
• src/bitcoin-wallet.cpp
• src/bitcoind.cpp
• src/rpc/mempool.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/{masternode,evo,llmq,governance,coinjoin}/**/*.{cpp,h} : Use Dash-specific database implementations: CFlatDB for persistent storage (MasternodeMetaStore, GovernanceStore, SporkStore, NetFulfilledRequestStore) and CDBWrapper extensions for Evolution/DKG/InstantSend/Quorum/RecoveredSigs data

Applied to files:

• src/bench/wallet_loading.cpp
• src/node/interfaces.cpp
• src/bench/crypto_hash.cpp

📚 Learning: 2025-06-09T16:43:20.996Z

Learnt from: kwvg
Repo: dashpay/dash PR: 6718
File: test/functional/test_framework/test_framework.py:2102-2102
Timestamp: 2025-06-09T16:43:20.996Z
Learning: In the test framework consolidation PR (#6718), user kwvg prefers to limit functional changes to those directly related to MasternodeInfo, avoiding scope creep even for minor improvements like error handling consistency.

Applied to files:

• test/functional/mempool_packages.py
• test/functional/mempool_package_limits.py
• test/functional/rpc_packages.py

📚 Learning: 2025-06-20T23:32:16.225Z

Learnt from: kwvg
Repo: dashpay/dash PR: 6726
File: test/functional/rpc_createmultisig.py:120-120
Timestamp: 2025-06-20T23:32:16.225Z
Learning: In the rpc_createmultisig.py test, the checkbalances() function correctly excludes 9 blocks from the balance calculation: 8 blocks from do_multisig() calls (2 blocks per call × 4 calls) plus 1 block from checkbalances() itself.

Applied to files:

• test/functional/mempool_packages.py

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/llmq/**/*.{cpp,h} : LLMQ quorums must support multiple configurations (50/60, 400/60, 400/85) for different services (ChainLocks, InstantSend, governance voting)

Applied to files:

• src/bench/bls_dkg.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/llmq/**/*.{cpp,h} : InstantSend implementation must provide distributed key generation for secure transaction locking with quorum consensus

Applied to files:

• src/bench/bls_dkg.cpp

📚 Learning: 2025-11-04T18:23:28.175Z

Learnt from: UdjinM6
Repo: dashpay/dash PR: 6933
File: src/governance/classes.cpp:147-154
Timestamp: 2025-11-04T18:23:28.175Z
Learning: In src/governance/classes.cpp, CSuperblock::GetPaymentsLimit intentionally uses synthetic difficulty constants (nBits = 1 for mainnet, powLimit for networks with min difficulty) and simple height-based V20 activation checks instead of actual chain block data. This is by design because superblocks themselves are "synthetic" governance payment blocks, not regular mined blocks.

Applied to files:

• src/wallet/wallet.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/governance/**/*.{cpp,h} : Governance implementation must support governance objects (proposals, triggers, superblock management) and on-chain voting with tallying

Applied to files:

• src/node/interfaces.cpp

📚 Learning: 2025-12-01T18:13:21.314Z

Learnt from: PastaPastaPasta
Repo: dashpay/dash PR: 7018
File: test/lint/lint-github-actions.py:1-9
Timestamp: 2025-12-01T18:13:21.314Z
Learning: In the Dash repository, the file test/util/data/non-backported.txt should only include C++ files (.cpp or .h) because it is used for running clang-format. Other file types (such as Python files, .ui files, etc.) should not be added to this list.

Applied to files:

• ci/dash/lint-tidy.sh

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/**/*.{cpp,h,hpp,cc} : Dash Core implementation must be written in C++20, requiring at least Clang 16 or GCC 11.1

Applied to files:

• ci/dash/lint-tidy.sh

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/{test,wallet/test}/**/*.{cpp,h} : Unit tests in src/test/ and src/wallet/test/ must use Boost::Test framework

Applied to files:

• ci/dash/lint-tidy.sh

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/{masternode,llmq,evo,coinjoin,governance}/**/*.{cpp,h} : Use unordered_lru_cache for efficient caching with LRU eviction in Dash-specific data structures

Applied to files:

• src/bench/crypto_hash.cpp

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/qt/**/*.{cpp,h} : GUI implementation in src/qt/ must use Qt 5

Applied to files:

• src/qt/main.cpp

📚 Learning: 2025-12-17T13:58:19.813Z

Learnt from: kwvg
Repo: dashpay/dash PR: 7072
File: src/qt/walletcontroller.cpp:520-528
Timestamp: 2025-12-17T13:58:19.813Z
Learning: In Dash Qt wallet code, prefer using existing Qt signals/slots (e.g., ShowProgress signals) for long-running operations instead of adding explicit QProgressDialog dialogs. This minimizes upstream deviations and simplifies backports. Apply this pattern to wallet-related Qt components (e.g., operations like rescanning) and rely on signal-based progress updates rather than bespoke dialogs.

Applied to files:

• src/qt/main.cpp

🧬 Code graph analysis (8)

src/common/url.h (1)

src/common/url.cpp (2)

• urlDecode (12-22)
• urlDecode (12-12)

src/wallet/scriptpubkeyman.h (1)

src/wallet/scriptpubkeyman.cpp (6)

• GetScriptPubKeys (2516-2519)
• GetScriptPubKeys (2516-2516)
• GetScriptPubKeys (2521-2531)
• GetScriptPubKeys (2521-2521)
• GetEndRange (2533-2536)
• GetEndRange (2533-2533)

src/interfaces/chain.h (2)

src/node/interfaces.cpp (14)

• filter_type (1072-1075)
• filter_type (1072-1072)
• filter_type (1076-1085)
• filter_type (1076-1076)
• block_hash (1056-1062)
• block_hash (1056-1056)
• block_hash (1124-1134)
• block_hash (1124-1124)
• block_hash (1135-1143)
• block_hash (1135-1135)
• block_hash (1159-1163)
• block_hash (1159-1159)
• block_hash (1164-1182)
• block_hash (1164-1164)

src/wallet/wallet.cpp (2)

• block_hash (319-322)
• block_hash (319-319)

test/functional/mempool_packages.py (3)

test/functional/test_framework/test_framework.py (1)

• is_specified_wallet_compiled (1114-1120)

test/functional/test_framework/p2p.py (1)

• wait_for_broadcast (1019-1026)

test/functional/test_framework/messages.py (1)

• get_vsize (593-594)

test/functional/test_framework/wallet.py (1)

test/functional/test_framework/util.py (2)

• assert_greater_than_or_equal (82-84)
• assert_equal (69-74)

test/functional/mempool_package_limits.py (1)

test/functional/test_framework/wallet.py (6)

• MiniWallet (74-366)
• send_self_transfer_chain (357-366)
• create_self_transfer (315-335)
• create_self_transfer_multi (260-313)
• send_self_transfer (226-230)
• sendrawtransaction (337-340)

test/functional/rpc_packages.py (5)

test/functional/test_framework/messages.py (1)

• tx_from_hex (230-232)

test/functional/test_framework/p2p.py (2)

• P2PTxInvStore (1001-1026)
• wait_for_broadcast (1019-1026)

test/functional/test_framework/util.py (2)

• assert_fee_amount (44-52)
• assert_raises_rpc_error (132-148)

test/functional/test_framework/wallet.py (5)

• MiniWallet (74-366)
• create_self_transfer (315-335)
• create_self_transfer_chain (342-355)
• create_self_transfer_multi (260-313)
• get_utxo (192-212)

test/functional/test_framework/test_node.py (1)

• get_deterministic_priv_key (191-194)

src/rpc/mempool.cpp (2)

src/wallet/rpc/spend.cpp (1)

• tx (983-983)

src/core_write.cpp (2)

• ValueFromAmount (36-47)
• ValueFromAmount (36-36)

🪛 Cppcheck (2.19.0)

src/bench/bls_pubkey_agg.cpp

[error] 95-95: failed to evaluate #if condition, undefined function-like macro invocation

(syntaxError)

src/node/interfaces.cpp

[error] 22-22: failed to evaluate #if condition, undefined function-like macro invocation

(syntaxError)

src/bench/peer_eviction.cpp

[error] 148-148: Buffer is accessed out of bounds

(bufferAccessOutOfBounds)

src/test/util/setup_common.cpp

[error] 10-10: failed to evaluate #if condition, undefined function-like macro invocation

(syntaxError)

🪛 Flake8 (7.3.0)

test/functional/wallet_fast_rescan.py

[error] 52-52: f-string is missing placeholders

(F541)

test/functional/rpc_packages.py

[error] 51-51: continuation line over-indented for hanging indent

(E126)

---

[error] 56-56: continuation line under-indented for hanging indent

(E121)

---

[error] 101-101: continuation line under-indented for visual indent

(E128)

🪛 Ruff (0.14.10)

test/functional/wallet_listtransactions.py

177-177: Prefer next(...) over single element slice

Replace with next(...)

(RUF015)

test/functional/wallet_fast_rescan.py

52-52: f-string without any placeholders

Remove extraneous f prefix

(F541)

test/functional/test_framework/wallet.py

290-290: zip() without an explicit strict= parameter

Add explicit value for parameter strict=

(B905)

test/functional/rpc_packages.py

120-120: Consider [tx_high_fee["hex"], *self.independent_txns_hex] instead of concatenation

Replace with [tx_high_fee["hex"], *self.independent_txns_hex]

(RUF005)

---

197-197: Consider [*package_hex, child_tx['hex']] instead of concatenation

Replace with [*package_hex, child_tx['hex']]

(RUF005)

---

202-202: Consider [*package_hex, child_tx["hex"]] instead of concatenation

Replace with [*package_hex, child_tx["hex"]]

(RUF005)

---

245-245: Unnecessary key check before dictionary access

Replace with dict.get

(RUF019)

---

260-260: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

test/functional/wallet_listsinceblock.py

413-413: Prefer next(...) over single element slice

Replace with next(...)

(RUF015)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

• GitHub Check: linux64_multiprocess-build / Build source
• GitHub Check: linux64_tsan-build / Build source
• GitHub Check: linux64_sqlite-build / Build source
• GitHub Check: linux64_fuzz-build / Build source
• GitHub Check: linux64-build / Build source
• GitHub Check: linux64_ubsan-build / Build source
• GitHub Check: mac-build / Build source
• GitHub Check: win64-build / Build source
• GitHub Check: arm-linux-build / Build source
• GitHub Check: linux64_nowallet-build / Build source

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Use equality (==) instead of identity (is) for txid comparison

Here:

if utxo['txid'] is parent_transaction:
    tx_children.append(txid)

is checks object identity, not string equality, and will be unreliable for txid strings. This can cause tx_children to be incomplete or empty and break the descendant/spentby checks.

Consider switching to ==:

Proposed fix

-            if utxo['txid'] is parent_transaction:
+            if utxo['txid'] == parent_transaction:
                 tx_children.append(txid)

🤖 Prompt for AI Agents

In @test/functional/mempool_packages.py around lines 231-239, The comparison
currently uses identity instead of equality: replace the identity check `if
utxo['txid'] is parent_transaction` with an equality check against the txid
string (i.e., compare utxo['txid'] == parent_transaction) so tx_children is
populated reliably when the utxo txid matches parent_transaction; update the
condition in the loop that builds chain/tx_children accordingly.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

submitpackage result indexing and broadcast wait should use txids, not tx.hash

In test_submit_child_with_parents:

for package_txn in package_txns:
    tx = package_txn["tx"]
    assert tx.hash in submitpackage_result["tx-results"]
    tx_result = submitpackage_result["tx-results"][tx.hash]
    ...
...
peer.wait_for_broadcast([tx["tx"].hash for tx in package_txns])

Two problems:

1. submitpackage_result["tx-results"] is keyed by txid strings, while tx.hash is an internal integer hash. The membership test and lookup are therefore unreliable and can fail with a KeyError.

2. P2PTxInvStore.wait_for_broadcast expects a list of hex txid strings and calls int(tx, 16) on each. Passing integer hashes (tx.hash) will raise a TypeError.

Both places should use the hex txid string (package_txn["txid"]).

Proposed fix

-        for package_txn in package_txns:
-            tx = package_txn["tx"]
-            assert tx.hash in submitpackage_result["tx-results"]
-            tx_result = submitpackage_result["tx-results"][tx.hash]
+        for package_txn in package_txns:
+            tx = package_txn["tx"]
+            assert package_txn["txid"] in submitpackage_result["tx-results"]
+            tx_result = submitpackage_result["tx-results"][package_txn["txid"]]
             assert_equal(tx_result, {
                 "txid": package_txn["txid"],
                 "size": tx.get_vsize(),
                 "fees": {
                     "base": DEFAULT_FEE,
                 }
             })
@@
-        self.bump_mocktime(30)
-        peer.wait_for_broadcast([tx["tx"].hash for tx in package_txns])
+        self.bump_mocktime(30)
+        peer.wait_for_broadcast([tx["txid"] for tx in package_txns])

🤖 Prompt for AI Agents

In @test/functional/rpc_packages.py around lines 268-293, In
test_submit_child_with_parents, replace uses of the internal integer tx.hash
with the hex txid string package_txn["txid"]: change the loop membership check
and lookup against submitpackage_result["tx-results"] to use package_txn["txid"]
(both the assert and tx_result assignment), and change the
peer.wait_for_broadcast call to pass a list of package_txn["txid"] strings
instead of tx["tx"].hash so wait_for_broadcast receives hex txid strings.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Same txid vs hash issue in CPFP submitpackage test

test_submit_cpfp has the same tx.hash vs txid and broadcast argument issue:

rich_parent_result = submitpackage_result["tx-results"][tx_rich["txid"]]
poor_parent_result = submitpackage_result["tx-results"][tx_poor["txid"]]
child_result = submitpackage_result["tx-results"][tx_child["tx"].hash]
...
peer.wait_for_broadcast([tx["tx"].hash for tx in package_txns])

Indexing the child result via tx_child["tx"].hash and passing integer hashes to wait_for_broadcast are inconsistent with the parent lookups and with P2PTxInvStore’s API.

Suggestion:

Proposed fix

-        child_result = submitpackage_result["tx-results"][tx_child["tx"].hash]
+        child_result = submitpackage_result["tx-results"][tx_child["txid"]]
@@
-        self.bump_mocktime(30)
-        peer.wait_for_broadcast([tx["tx"].hash for tx in package_txns])
+        self.bump_mocktime(30)
+        peer.wait_for_broadcast([tx["txid"] for tx in package_txns])

This keeps all indexing and broadcast waiting consistently based on txid strings.

🤖 Prompt for AI Agents

In @test/functional/rpc_packages.py around lines 295-323, In test_submit_cpfp
the child transaction is being referenced by tx_child["tx"].hash and
wait_for_broadcast is passed integer hashes, which is inconsistent with the
parent lookups (tx_rich/tx_poor using "txid") and P2PTxInvStore API; change the
child lookup to use submitpackage_result["tx-results"][tx_child["txid"]] and
pass txid strings to peer.wait_for_broadcast by using [tx["txid"] for tx in
package_txns] so all indexing and broadcast checking consistently use txid
strings (update references to tx_child, package_txns, submitpackage_result, and
peer.wait_for_broadcast accordingly).