chore(release): update changelog and bump version to 3.0.0-dev.11 #2970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 WalkthroughWalkthroughThis PR increments package versions from 3.0.0-dev.10 to 3.0.0-dev.11 across the workspace (with dash-spv, wallet-lib, and js-dash-sdk at their respective major versions), updates the root Cargo.toml and package.json manifests, and documents the 3.0.0-dev.11 release in CHANGELOG.md with breaking changes, features, and bug fixes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @CHANGELOG.md:
- Around line 1-27: The changelog currently lists "**sdk:** failed address sync
on invalid proof (#2967)" under both "⚠ BREAKING CHANGES" and "Bug Fixes";
decide and fix this by either removing that bullet from the "⚠ BREAKING CHANGES"
section if it is only a behavior-hardening bug, or keep it there but append a
short parenthetical clarifier to the same bullet (e.g., "(stricter validation
may cause previously-accepted proofs to be rejected)") so readers know why it is
breaking; update the single bullet for `**sdk:** failed address sync on invalid
proof (#2967)` accordingly.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (26)
CHANGELOG.mdCargo.tomlpackage.jsonpackages/bench-suite/package.jsonpackages/dapi-grpc/package.jsonpackages/dapi/package.jsonpackages/dash-spv/package.jsonpackages/dashmate/package.jsonpackages/dashpay-contract/package.jsonpackages/dpns-contract/package.jsonpackages/feature-flags-contract/package.jsonpackages/js-dapi-client/package.jsonpackages/js-dash-sdk/package.jsonpackages/js-evo-sdk/package.jsonpackages/js-grpc-common/package.jsonpackages/keyword-search-contract/package.jsonpackages/masternode-reward-shares-contract/package.jsonpackages/platform-test-suite/package.jsonpackages/token-history-contract/package.jsonpackages/wallet-lib/package.jsonpackages/wallet-utils-contract/package.jsonpackages/wasm-dpp/package.jsonpackages/wasm-dpp2/package.jsonpackages/wasm-drive-verify/package.jsonpackages/wasm-sdk/package.jsonpackages/withdrawals-contract/package.json
🧰 Additional context used
🧠 Learnings (20)
📓 Common learnings
Learnt from: QuantumExplorer
Repo: dashpay/platform PR: 2431
File: packages/rs-drive/Cargo.toml:55-60
Timestamp: 2025-01-19T07:36:46.042Z
Learning: The grovedb dependencies in packages/rs-drive/Cargo.toml and related files are intentionally kept at specific revisions rather than using the latest stable version, with plans to update them at a later time.
Learnt from: QuantumExplorer
Repo: dashpay/platform PR: 2257
File: packages/rs-drive-abci/src/mimic/test_quorum.rs:159-164
Timestamp: 2024-11-20T16:16:01.830Z
Learning: QuantumExplorer prefers not to receive auto-generated messages asking to post on social media.
📚 Learning: 2025-11-25T13:10:23.481Z
Learnt from: CR
Repo: dashpay/platform PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T13:10:23.481Z
Learning: Applies to **/swift-sdk/**/*.{swift,h,m,c} : iOS SDK must combine both Core (SPV wallet) and Platform (identity/documents) functionality in the unified SDK with proper function naming: `dash_core_sdk_*` prefix for Core functions, `dash_sdk_*` prefix for Platform functions, and `dash_unified_sdk_*` prefix for unified functions
Applied to files:
CHANGELOG.md
📚 Learning: 2025-09-03T14:42:29.958Z
Learnt from: thephez
Repo: dashpay/platform PR: 2754
File: packages/wasm-sdk/docs.html:1970-1971
Timestamp: 2025-09-03T14:42:29.958Z
Learning: In packages/wasm-sdk/, the docs.html file is auto-generated from api-definitions.json. Any documentation fixes should be made in api-definitions.json rather than directly in docs.html, as manual changes to docs.html would be overwritten during regeneration.
Applied to files:
packages/wasm-drive-verify/package.jsonpackages/wasm-sdk/package.json
📚 Learning: 2025-09-03T14:41:16.196Z
Learnt from: thephez
Repo: dashpay/platform PR: 2754
File: packages/wasm-sdk/AI_REFERENCE.md:766-766
Timestamp: 2025-09-03T14:41:16.196Z
Learning: In packages/wasm-sdk/, the AI_REFERENCE.md file is auto-generated from api-definitions.json. Any documentation fixes should be made in api-definitions.json rather than directly in AI_REFERENCE.md, as manual changes to AI_REFERENCE.md would be overwritten during regeneration.
Applied to files:
packages/wasm-sdk/package.json
📚 Learning: 2025-07-28T20:00:08.502Z
Learnt from: QuantumExplorer
Repo: dashpay/platform PR: 2711
File: packages/wasm-sdk/AI_REFERENCE.md:771-783
Timestamp: 2025-07-28T20:00:08.502Z
Learning: In packages/wasm-sdk/AI_REFERENCE.md, the documentation correctly shows the actual SDK method signatures (including identityCreate and identityTopUp with their full parameter lists), which may differ from the UI inputs shown in fixed_definitions.json. The UI may collect fewer parameters from users while handling additional requirements internally.
Applied to files:
packages/wasm-sdk/package.json
📚 Learning: 2025-09-03T19:33:21.688Z
Learnt from: thephez
Repo: dashpay/platform PR: 2754
File: packages/wasm-sdk/api-definitions.json:1285-1285
Timestamp: 2025-09-03T19:33:21.688Z
Learning: In packages/wasm-sdk/api-definitions.json, thephez prefers to keep the existing "ripemd160hash20bytes1234" placeholder for ECDSA_HASH160 data field in documentation examples rather than using a valid base64-encoded format, maintaining consistency with the previous documentation approach.
Applied to files:
packages/wasm-sdk/package.json
📚 Learning: 2025-11-25T13:10:23.481Z
Learnt from: CR
Repo: dashpay/platform PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T13:10:23.481Z
Learning: Use JavaScript/TypeScript for client SDKs, developer tools, and test suite
Applied to files:
packages/wasm-sdk/package.jsonpackages/js-evo-sdk/package.json
📚 Learning: 2025-09-02T13:30:17.703Z
Learnt from: thephez
Repo: dashpay/platform PR: 2739
File: packages/wasm-sdk/test/ui-automation/tests/state-transitions.spec.js:1-171
Timestamp: 2025-09-02T13:30:17.703Z
Learning: In packages/wasm-sdk/index.html, state transition definitions are loaded dynamically from api-definitions.json via the loadApiDefinitions() function that fetches './api-definitions.json'. The UI doesn't have hardcoded transition definitions - instead it populates categories, types, inputs, and labels from this JSON configuration file at runtime.
Applied to files:
packages/wasm-sdk/package.json
📚 Learning: 2025-10-15T14:45:30.856Z
Learnt from: lklimek
Repo: dashpay/platform PR: 2716
File: packages/dashmate/src/test/constants/services.js:4-4
Timestamp: 2025-10-15T14:45:30.856Z
Learning: In the dashmate codebase (packages/dashmate), during the DAPI Rust migration (rs-dapi), the old service keys `dapi_api` and `dapi_core_streams` are intentionally kept in `generateEnvsFactory.js` for backward compatibility even though the test constants in `src/test/constants/services.js` have been updated to use `rs_dapi`. These deprecated keys will be removed in a future PR after the transition is complete.
Applied to files:
packages/js-dash-sdk/package.jsonpackages/dapi/package.jsonpackages/dashmate/package.json
📚 Learning: 2025-09-22T05:59:31.140Z
Learnt from: shumkov
Repo: dashpay/platform PR: 2783
File: packages/js-evo-sdk/tests/functional/dpns.spec.mjs:2-2
Timestamp: 2025-09-22T05:59:31.140Z
Learning: The dist/evo-sdk.module.js file in packages/js-evo-sdk is a generated build artifact created during the build process, not a source file that should exist in the repository.
Applied to files:
packages/js-evo-sdk/package.json
📚 Learning: 2025-07-10T00:37:09.586Z
Learnt from: QuantumExplorer
Repo: dashpay/platform PR: 2690
File: packages/wasm-sdk/src/queries/document.rs:383-384
Timestamp: 2025-07-10T00:37:09.586Z
Learning: In the Dash platform, DPNS (Dash Platform Name Service) contracts have the same ID across all networks (mainnet, testnet, etc.), so hardcoding the DPNS contract ID is appropriate and doesn't need to be configurable.
Applied to files:
packages/dpns-contract/package.json
📚 Learning: 2025-10-23T13:04:39.160Z
Learnt from: thephez
Repo: dashpay/platform PR: 2816
File: packages/js-dapi-client/lib/networkConfigs.js:17-40
Timestamp: 2025-10-23T13:04:39.160Z
Learning: For the testnet DAPI address whitelist in packages/js-dapi-client/lib/networkConfigs.js, nodes may be intentionally excluded even if they are ENABLED if they are running pre-2.1 versions. Version compatibility is an important filtering criterion beyond just enabled status.
Applied to files:
packages/dapi/package.json
📚 Learning: 2024-10-09T00:22:57.778Z
Learnt from: shumkov
Repo: dashpay/platform PR: 2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Applied to files:
packages/dashmate/package.json
📚 Learning: 2025-12-29T10:53:11.383Z
Learnt from: shumkov
Repo: dashpay/platform PR: 2868
File: packages/wasm-sdk/tests/functional/addresses.spec.mjs:75-95
Timestamp: 2025-12-29T10:53:11.383Z
Learning: In the dashpay/platform repository, the dirty-chai plugin is used for Chai assertions in test files. This makes function-call assertion syntax like `expect(...).to.be.ok()` valid and correct, rather than the standard property-based syntax `expect(...).to.be.ok`.
Applied to files:
packages/platform-test-suite/package.json
📚 Learning: 2025-10-29T11:37:57.299Z
Learnt from: lklimek
Repo: dashpay/platform PR: 2818
File: packages/dashmate/test/unit/templates/dynamicCompose.spec.js:1-4
Timestamp: 2025-10-29T11:37:57.299Z
Learning: In the dashpay/platform repository's dashmate package (packages/dashmate), test files do not need to import `expect` from chai because test/bootstrap.js sets it up globally with `global.expect = expect;`. The bootstrap file is automatically loaded by Mocha.
Applied to files:
packages/platform-test-suite/package.json
📚 Learning: 2024-10-17T08:52:54.300Z
Learnt from: shumkov
Repo: dashpay/platform PR: 2248
File: packages/rs-drive-abci/src/main.rs:106-111
Timestamp: 2024-10-17T08:52:54.300Z
Learning: In this project, the environment variable `CARGO_PKG_RUST_VERSION` is defined and can be used safely with the `env!` macro.
Applied to files:
Cargo.toml
📚 Learning: 2025-11-25T13:10:23.481Z
Learnt from: CR
Repo: dashpay/platform PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T13:10:23.481Z
Learning: Run Rust tests for packages using `cargo test -p <package_name>` and all Rust tests with `cargo test --workspace`
Applied to files:
Cargo.toml
📚 Learning: 2024-10-18T15:39:51.172Z
Learnt from: lklimek
Repo: dashpay/platform PR: 2254
File: packages/rs-sdk/src/sdk.rs:585-585
Timestamp: 2024-10-18T15:39:51.172Z
Learning: The 'platform' project uses Rust version 1.80, so code in 'packages/rs-sdk' can use features available in Rust 1.80, such as the `abs_diff()` method.
Applied to files:
Cargo.toml
📚 Learning: 2025-01-19T07:36:46.042Z
Learnt from: QuantumExplorer
Repo: dashpay/platform PR: 2431
File: packages/rs-drive/Cargo.toml:55-60
Timestamp: 2025-01-19T07:36:46.042Z
Learning: The grovedb dependencies in packages/rs-drive/Cargo.toml and related files are intentionally kept at specific revisions rather than using the latest stable version, with plans to update them at a later time.
Applied to files:
Cargo.toml
📚 Learning: 2025-10-09T16:00:42.724Z
Learnt from: lklimek
Repo: dashpay/platform PR: 2716
File: packages/rs-dash-event-bus/Cargo.toml:4-4
Timestamp: 2025-10-09T16:00:42.724Z
Learning: Rust edition 2024 was released and stabilized in Rust 1.85 on February 20, 2025. Using `edition = "2024"` in Cargo.toml is valid and supported.
Applied to files:
Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (77)
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Rust crates security audit
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Rust crates security audit
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Rust crates security audit
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Rust crates security audit
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Rust crates security audit
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Rust crates security audit
- GitHub Check: Rust packages (wasm-sdk) / Detect immutable structure changes
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Rust crates security audit
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Detect immutable structure changes
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Rust crates security audit
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Detect immutable structure changes
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Rust crates security audit
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (wasm-sdk) / Detect immutable structure changes
- GitHub Check: Rust packages (dapi-grpc) / Check each feature
- GitHub Check: Rust packages (dapi-grpc) / Linting
- GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (wasm-sdk) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Rust crates security audit
🔇 Additional comments (25)
packages/keyword-search-contract/package.json (1)
3-3: LGTM! Version bump is consistent.The version has been correctly updated to 3.0.0-dev.11 as part of the release process.
package.json (1)
3-3: LGTM! Root version bump is correct.The root package version has been properly updated to 3.0.0-dev.11, coordinating with the workspace-wide version bump.
packages/dashpay-contract/package.json (1)
3-3: LGTM! Version bump is consistent.The version has been correctly updated to 3.0.0-dev.11 as part of the release process.
packages/dapi-grpc/package.json (1)
3-3: LGTM! Version bump is consistent.The version has been correctly updated to 3.0.0-dev.11 as part of the release process.
packages/platform-test-suite/package.json (1)
4-4: LGTM! Version bump is consistent.The version has been correctly updated to 3.0.0-dev.11 as part of the release process.
packages/wasm-dpp/package.json (1)
3-3: LGTM! Version bump is clean and consistent.The version increment from 3.0.0-dev.10 to 3.0.0-dev.11 is appropriate for this pre-release.
packages/wasm-drive-verify/package.json (1)
6-6: LGTM! Version bump is correct.Consistent version increment to 3.0.0-dev.11.
packages/js-evo-sdk/package.json (1)
3-3: LGTM! Version increment is consistent.The version bump aligns with the release objectives, and the workspace dependency will automatically resolve to the correct version.
packages/token-history-contract/package.json (1)
3-3: LGTM! Version update is proper.Clean version bump to 3.0.0-dev.11 with no extraneous changes.
Cargo.toml (1)
48-48: LGTM! Workspace version bump is correct.The workspace version increment to 3.0.0-dev.11 will propagate appropriately to all member packages.
packages/js-dash-sdk/package.json (1)
3-3: Version bump looks correct.The version increment from 6.0.0-dev.10 to 6.0.0-dev.11 is consistent with the release objectives.
packages/wallet-lib/package.json (1)
3-3: Version bump looks correct.The version increment from 10.0.0-dev.10 to 10.0.0-dev.11 aligns with the release process.
packages/masternode-reward-shares-contract/package.json (1)
3-3: Version bump looks correct.The version increment from 3.0.0-dev.10 to 3.0.0-dev.11 is consistent with the coordinated release.
packages/dash-spv/package.json (1)
3-3: Version bump looks correct.The version increment from 4.0.0-dev.10 to 4.0.0-dev.11 is appropriate for this release.
packages/bench-suite/package.json (1)
4-4: Version bump looks correct.The version increment from 3.0.0-dev.10 to 3.0.0-dev.11 is consistent with the release process.
packages/wasm-sdk/package.json (1)
3-3: LGTM! Version bump is correct.The version has been properly incremented to 3.0.0-dev.11, consistent with the release objectives.
packages/withdrawals-contract/package.json (1)
3-3: LGTM! Version bump is correct.The version has been properly incremented to 3.0.0-dev.11.
packages/js-dapi-client/package.json (1)
3-3: LGTM! Version bump is correct.The version has been properly incremented to 3.0.0-dev.11.
packages/js-grpc-common/package.json (1)
3-3: LGTM! Version bump is correct.The version has been properly incremented to 3.0.0-dev.11.
packages/wallet-utils-contract/package.json (1)
3-3: LGTM! Version bump is correct.The version has been properly incremented to 3.0.0-dev.11.
packages/feature-flags-contract/package.json (1)
3-3: LGTM! Version bump is correct.The version increment from 3.0.0-dev.10 to 3.0.0-dev.11 aligns with the release objectives.
packages/dashmate/package.json (1)
3-3: LGTM! Version bump is correct.The version increment to 3.0.0-dev.11 is consistent with the release.
packages/dapi/package.json (1)
4-4: LGTM! Version bump is correct.The version has been properly incremented to 3.0.0-dev.11.
packages/wasm-dpp2/package.json (1)
3-3: LGTM! Version bump is correct.The version increment to 3.0.0-dev.11 is consistent with the release objectives.
packages/dpns-contract/package.json (1)
3-3: Version bump to 3.0.0-dev.11 is correct and consistent across the workspace.Verification confirms all packages have been updated with no remaining 3.0.0-dev.10 versions.
Comment on lines
+1
to
+27
| ## [3.0.0-dev.11](https://github.com/dashpay/platform/compare/v3.0.0-dev.10...v3.0.0-dev.11) (2026-01-08) | ||
|
|
||
|
|
||
| ### ⚠ BREAKING CHANGES | ||
|
|
||
| * **sdk:** failed address sync on invalid proof (#2967) | ||
| * **platform:** add block-aware credit operations to manage address balance changes (#2968) | ||
| * **platform:** enhanced fetching of compacted address balance changes (#2966) | ||
|
|
||
| ### Features | ||
|
|
||
| * **platform:** add block-aware credit operations to manage address balance changes ([#2968](https://github.com/dashpay/platform/issues/2968)) | ||
| * **platform:** add tests for proof verification of recent address balance changes ([#2969](https://github.com/dashpay/platform/issues/2969)) | ||
| * **platform:** enhanced fetching of compacted address balance changes ([#2966](https://github.com/dashpay/platform/issues/2966)) | ||
| * **platform:** remove platform version patching and state migration logic ([#2961](https://github.com/dashpay/platform/issues/2961)) | ||
| * **platform:** update address expiration time from 1 day to 1 week ([#2964](https://github.com/dashpay/platform/issues/2964)) | ||
| * **sdk:** return checkpoint height with `AddressSyncResult` ([#2965](https://github.com/dashpay/platform/issues/2965)) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * **rs-sdk-ffi:** auto-increment document revision in replace function ([#2960](https://github.com/dashpay/platform/issues/2960)) | ||
| * **sdk:** adjust metadata freshness criteria for get_addresses_trunk_state and get_addresses_branch_state ([#2954](https://github.com/dashpay/platform/issues/2954)) | ||
| * **sdk:** clamp address sync branch query depth to platform limits ([#2955](https://github.com/dashpay/platform/issues/2955)) | ||
| * **sdk:** failed address sync on invalid proof ([#2967](https://github.com/dashpay/platform/issues/2967)) | ||
| * **sdk:** match `ItemWithSumItem` in `extract_balance_from_element` ([#2956](https://github.com/dashpay/platform/issues/2956)) | ||
|
|
Contributor
There was a problem hiding this comment.
Clarify whether sdk change #2967 is truly a breaking change
**sdk:** failed address sync on invalid proof (#2967) is listed both under “⚠ BREAKING CHANGES” and under “Bug Fixes”. If the change is only behavior-hardening (rejecting bad proofs) and not a protocol/API break, consider either:
- removing it from the “⚠ BREAKING CHANGES” list, or
- briefly clarifying in that bullet why it’s breaking (e.g., stricter validation that can cause previously-accepted flows to fail).
This will make the impact clearer for integrators scanning the changelog.
🤖 Prompt for AI Agents
In @CHANGELOG.md around lines 1 - 27, The changelog currently lists "**sdk:**
failed address sync on invalid proof (#2967)" under both "⚠ BREAKING CHANGES"
and "Bug Fixes"; decide and fix this by either removing that bullet from the "⚠
BREAKING CHANGES" section if it is only a behavior-hardening bug, or keep it
there but append a short parenthetical clarifier to the same bullet (e.g.,
"(stricter validation may cause previously-accepted proofs to be rejected)") so
readers know why it is breaking; update the single bullet for `**sdk:** failed
address sync on invalid proof (#2967)` accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Release new Dash Platform version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.