Skip to content

docs: quote pip extras install examples#2093

Merged
SharonHart merged 6 commits into
data-privacy-stack:mainfrom
nyxst4ck:nyxst4ck/auto-quote-pip-extras-20260623-142800
Jul 15, 2026
Merged

docs: quote pip extras install examples#2093
SharonHart merged 6 commits into
data-privacy-stack:mainfrom
nyxst4ck:nyxst4ck/auto-quote-pip-extras-20260623-142800

Conversation

@nyxst4ck

Copy link
Copy Markdown
Contributor

Summary

  • Quote pip install examples that include extras.

Why

  • Shells such as zsh can expand unquoted bracket expressions before pip receives them.

Scope

  • Files changed:
  • docs/ahds_integration.md
  • docs/samples/python/langextract/index.md
  • presidio-analyzer/README.md
  • This does not change dependencies or runtime behavior.

Testing

  • git diff --check

Maintainer Fit

  • Small install-command correctness fix.
  • Duplicate PR search terms checked: quote pip extras, quote optional dependency, zsh pip install extras, pip extras install examples

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates documentation install commands to quote pip install ...[extra] examples so shells like zsh don’t expand bracket expressions before pip receives them.

Changes:

  • Quoted pip install examples for presidio-analyzer[langextract] in analyzer README and LangExtract sample docs.
  • Quoted pip install examples for AHDS extras in AHDS integration docs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
presidio-analyzer/README.md Quotes the pip install example for the langextract extra.
docs/samples/python/langextract/index.md Quotes the pip install examples for the langextract extra (two occurrences).
docs/ahds_integration.md Quotes pip install examples for the ahds extras (analyzer/anonymizer, plus troubleshooting).

Comment thread presidio-analyzer/README.md Outdated
Comment thread docs/samples/python/langextract/index.md Outdated
Comment thread docs/samples/python/langextract/index.md Outdated
Comment thread docs/ahds_integration.md Outdated
Comment thread docs/ahds_integration.md Outdated
Comment thread docs/ahds_integration.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@omri374
omri374 marked this pull request as ready for review July 9, 2026 21:15
Copilot AI review requested due to automatic review settings July 9, 2026 21:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread docs/ahds_integration.md
@SharonHart

Copy link
Copy Markdown
Contributor

@nyxst4ck can you address the comments?

@nyxst4ck

Copy link
Copy Markdown
Contributor Author

Addressed the review comments:

  • switched the remaining extras install examples from single quotes to double quotes for Windows CMD compatibility
  • restored indentation for the pip install line inside the numbered-list code fence in docs/ahds_integration.md

Pushed as c2c44ae.

@SharonHart
SharonHart merged commit 0ac87d5 into data-privacy-stack:main Jul 15, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants