Implement OpenTelemetry and Prometheus tracing for SQLRunner #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pan93412
commented
Dec 28, 2025
pan93412
commented
- feat: add Prometheus metrics
- feat: implement OpenTelemetry tracing and logging
- feat: implement tracing
There was a problem hiding this comment.
Pull request overview
This PR implements comprehensive observability for SQLRunner by adding OpenTelemetry tracing and logging support, along with Prometheus metrics via Gin middleware. The implementation includes graceful shutdown handling and configurable exporters for traces and logs.
Key changes:
- Added OpenTelemetry SDK integration with configurable exporters (console/OTLP) for both traces and logs
- Integrated Prometheus metrics via ginprom middleware exposed at
/metricsendpoint - Implemented graceful shutdown with signal handling for proper cleanup of telemetry resources
- Added distributed tracing spans to request handling and SQLite query execution paths
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| otelprovider.go | New file implementing OpenTelemetry SDK bootstrap with configurable trace and log exporters supporting console and OTLP protocols |
| main.go | Migrated from standard library HTTP to Gin framework, added OpenTelemetry tracing, Prometheus metrics, graceful shutdown, and span instrumentation for request handling |
| lib/sqlrunner.go | Added tracing spans and events to Query method for cache operations and SQLite query execution |
| lib/otel.go | New file defining tracer instance for the sqlrunner library package |
| go.mod | Added dependencies for Gin, ginprom, OpenTelemetry SDK, exporters, and instrumentation |
| go.sum | Updated checksums for all new dependencies |
| README.md | Added Observability section documenting metrics endpoint and OpenTelemetry configuration environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.