feat: add configurable retry parameters and improve retry logging#739
Merged
everpcpc merged 3 commits intodatabendlabs:mainfrom Jan 15, 2026
Merged
feat: add configurable retry parameters and improve retry logging#739everpcpc merged 3 commits intodatabendlabs:mainfrom
everpcpc merged 3 commits intodatabendlabs:mainfrom
Conversation
- Add retry_count and retry_delay_secs DSN parameters (default: 3 retries, 10s delay) - Improve retry logs with detailed reasons (503, timeout, connection error, token refresh) - Refactor retry logic with RetryDecision struct in separate retry.rs module
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3aa79a9fe3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When retry_count=0, the expression `max_retries - 1` would underflow: - In debug builds: panic on subtraction - In release builds: wrap to u32::MAX, causing infinite retry loops This fix uses saturating_sub(1) which returns 0 when max_retries=0, allowing retry_count=0 to work correctly (no retries, fail immediately). Fixes applied in: - refresh_session_token: two comparisons with max_retries - 1 - query_request_helper: two comparisons with max_retries - 1 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds configurable retry parameters and improves retry logging for better observability and control over retry behavior.
What changed:
retry_count(default: 3) andretry_delay_secs(default: 10)RetryDecisionstruct in a newretry.rsmoduleWhy:
Key changes:
core/src/client.rs: Addedretry_countandretry_delay_secsfields, updated retry loops with improved loggingcore/src/retry.rs: New module withRetryDecisionhelper structrefresh_session_token()andrequest_helper()methods now use configurable parameters and provide detailed retry reasonsTesting notes:
?retry_count=5&retry_delay_secs=5