feat: map geo type to string or binary.#767
Merged
youngsofun merged 5 commits intodatabendlabs:mainfrom Apr 14, 2026
Merged
Conversation
youngsofun
force-pushed
the
feat/arrow_geo
branch
3 times, most recently
from
ef35d29 to
de50a81
Compare
youngsofun
force-pushed
the
feat/arrow_geo
branch
from
6261ce2 to
f869021
Compare
youngsofun
force-pushed
the
feat/arrow_geo
branch
from
8c862c3 to
6a74a77
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49ce796e2d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates geo type handling across the Rust driver and language bindings so Geometry/Geography can map to either text or binary output depending on geometry_output_format. The core SQL value layer now
carries geo values as a dedicated GeoValue enum (String or Binary) instead of forcing everything through string conversion, which removes the old geo/geozero-based conversion path and aligns decoding with Databend’s
result format settings.
The Python and Node.js bindings were updated to expose these values correctly:
related server side pr databendlabs/databend#19676