-
Notifications
You must be signed in to change notification settings - Fork 40
Use async wait timeout for SEA when direct results disabled (fix hybrid-path truncation) #1476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -740,9 +740,9 @@ private ExecuteStatementRequest getRequest( | |
| if (executeAsync) { | ||
| request.setWaitTimeout(ASYNC_TIMEOUT_VALUE); | ||
| } else { | ||
| // Only set timeout if direct results mode is not enabled | ||
| // DirectResults off -> async (0s); avoids truncation (ES-1714092) | ||
| if (!connectionContext.getDirectResultMode()) { | ||
| request.setWaitTimeout(SYNC_TIMEOUT_VALUE); | ||
| request.setWaitTimeout(ASYNC_TIMEOUT_VALUE); | ||
| } | ||
| request.setOnWaitTimeout(ExecuteStatementRequestOnWaitTimeout.CONTINUE); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this needed for async case?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is pre existing line - unchanged by this PR. It might not be required for async mode, but its better to be explicit than missing it out for some edge case (in any future changes) |
||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we add a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the unit tests