Skip to content

Redact access token before logging in setClientInfoProperty #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sreekanth-db wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

Redact access token before logging in setClientInfoProperty #1498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### Updated

### Fixed
- Fixed access token exposure in DEBUG logs.
- Fixed `setCatalog()` and `setSchema()` producing invalid SQL (e.g. `SET CATALOG ``name``) when the catalog or schema name was passed already wrapped in backticks. Backticks are now stripped before wrapping, and `getCatalog()`/`getSchema()` return the bare identifier name.
- Fixed metadata SQL generation for catalog, schema, and table identifiers containing backticks.
- Fixed SEA result truncation when direct results are disabled. Large, highly-compressible results that span multiple chunks were delivered inline via the old hybrid path and truncated to the first chunk. The SQL Execution path now uses an async (`0s`) wait timeout when direct results are disabled, so results are returned via external links and fetched in full.
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/com/databricks/jdbc/api/impl/DatabricksSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,15 +326,15 @@ public String getConfigValue(String name) {

@Override
public void setClientInfoProperty(String name, String value) {
LOGGER.debug(
String.format(
"public void setClientInfoProperty(String name = {%s}, String value = {%s})",
name, value));
if (name.equalsIgnoreCase(DatabricksJdbcUrlParams.AUTH_ACCESS_TOKEN.getParamName())) {
// refresh the access token if provided a new value in client info
this.databricksClient.resetAccessToken(value);
value = REDACTED_TOKEN; // mask access token
value = REDACTED_TOKEN; // mask access token before it is logged
}
LOGGER.debug(
String.format(
"public void setClientInfoProperty(String name = {%s}, String value = {%s})",
name, value));

// If application name is being set, update both telemetry and user agent
if (name.equalsIgnoreCase(DatabricksJdbcUrlParams.APPLICATION_NAME.getParamName())) {
Expand Down
Loading