Redact Azure and GCS presigned URL credentials in logs#1501
Open
sreekanth-db wants to merge 1 commit into
Open
Redact Azure and GCS presigned URL credentials in logs#1501sreekanth-db wants to merge 1 commit into
sreekanth-db wants to merge 1 commit into
Conversation
RequestSanitizer only redacted three AWS query params (case-sensitively), so Azure SAS (sig) and GCS (X-Goog-Signature/Credential) presigned URLs were logged with usable credentials. Extends the redaction set to cover all three clouds and matches case-insensitively. Co-authored-by: Isaac Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestSanitizerpreviously redacted only three AWS query parameters, and matched them case-sensitively. As a result, presigned URLs for other cloud backends were logged with their credentials intact. This extends redaction to cover the signature/credential parameters of all supported clouds and matches them case-insensitively.Changes
RequestSanitizer: add Azure and GCS signature/credential query params to the redaction set; switch the lookup to case-insensitive (TreeSetwithString.CASE_INSENSITIVE_ORDER).Testing
RequestSanitizerTest— all pass (8 tests).Full detail tracked privately in the associated security ticket.
This pull request and its description were written by Isaac.