Preserve filesystem prefixes embedded in paths - #1498
Open
abdulm5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Abdul Mohammad <abdul.mohammad9087@gmail.com>
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
abdulm5
marked this pull request as ready for review
July 28, 2026 02:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #854
Summary
Preserves
dbfs:andfile:text when it appears inside DBFS, Volume,or local path names while continuing to normalize leading filesystem
scheme prefixes.
Why
Path wrappers currently use global string replacement to remove filesystem
prefixes. This also removes matching text from legitimate path components,
making paths such as
/dbfs:unreachable.When recursively listing
/, a returned/dbfs:directory is normalizedback to
/and queued again, causing an infinite traversal loop. Restrictingnormalization to the beginning of the path preserves legitimate names and
prevents this aliasing.
What changed
Interface changes
None.
Behavioral changes
dbfs:andfile:text is preserved.dbfs:andfile:scheme prefixes retain their existing behavior.dbfs:orfile:.Internal changes
file:handling prefix-only while preserving Windows file URIand UNC behavior.
How is this tested?
tests/test_dbfs_mixins.py: 30 passed.git diff --check: passed.