Skip to content

Increase the buffer size for arguments #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lindsh123 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Increase the buffer size for arguments #177

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67fc5df
increased buffer size
lindsh123 Jun 4, 2026
207d2ba
semicolon
lindsh123 Jun 8, 2026
4dd648f
invalid error check
lindsh123 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/protocol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ static bool spawn_process(struct pss_tty *pss, uint16_t columns, uint16_t rows)
char *filePath = xmalloc(file_path_len);
snprintf(filePath, file_path_len, "%sXXXXXX", server->arg_file);

if ((fd = mkstemp(filePath)) != -1) {
if ((fd = mkstemp(filePath)) == -1) {
lwsl_err("Creation of temp file failed with error: %d (%s)\n", errno, strerror(errno));
return false;
}
Expand All @@ -124,7 +124,7 @@ static bool spawn_process(struct pss_tty *pss, uint16_t columns, uint16_t rows)

if (close(fd) != 0) {
lwsl_err("Close temp file failed with error: %d (%s)\n", errno, strerror(errno));
return false
return false;
}
argv[n++] = filePath;
}
Expand Down Expand Up @@ -166,7 +166,7 @@ static void wsi_output(struct lws *wsi, pty_buf_t *buf) {
int callback_tty(struct lws *wsi, enum lws_callback_reasons reason, void *user, void *in,
size_t len) {
struct pss_tty *pss = (struct pss_tty *)user;
char buf[256];
char buf[1024];
size_t n = 0;

switch (reason) {
Expand Down