test: run parse-offline auth guards on all SDK versions#1558
Merged
Conversation
The offline-parse guards were skipped on the min-deps floor (sdk 0.68.0) because the class was gated on the databricks-sdk>=0.103 host-metadata probe. That gate is wrong for non-PAT auth, where building Config does OIDC discovery (a network call on every SDK) -- the path #940 hit on 1.10.x. Drop the gate and its now-dead marker/import so the guards run on all SDK versions, including min-deps.
Coverage report
This PR does not seem to contain any modification to coverable code. |
jprakash-db
approved these changes
Jun 25, 2026
Collaborator
Author
|
/integration-test min-deps |
|
Min-deps integration tests dispatched for PR #1558 by @sd-db. Track progress in the Actions tab. |
|
Min-deps integration results for PR #1558 — UC cluster ✅ success · SQL warehouse ✅ success · All-purpose cluster ✅ success · Shard coverage ✅ success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TestParseTimeIsOfflineandTestEnsureConfigTriggersTheRightAuthwere gated on thedatabricks-sdk>=0.103host-metadata probe, so they were skipped on the min-deps floor (sdk 0.68.0). That gate is wrong for non-PAT auth: building a non-PATConfigdoes OIDC discovery — a network call on every SDK version (the path #940 hit on 1.10.x), not just probe-carrying ones. Drop the gate and its now-dead marker/import so both guards run on all SDK versions.Test-only, pure deletion (−11 lines). Verified passing on sdk 0.117 and on the floor sdk 0.68.0 (skipped there before).
Context: #940 — the bug itself shipped fixed in 1.12.1 (#1474); this just hardens the regression guard.
Checklist
CHANGELOG.md— n/a (test-only, not user-facing)