-
Notifications
You must be signed in to change notification settings - Fork 86
Ak/spec #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anupkalburgi
wants to merge
10
commits into
master
Choose a base branch
from
ak/spec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ak/spec #372
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
20db964
working test wireup
anupkalburgi 4e9cba5
Initial code, spec and test, pushing for review
anupkalburgi d37de68
fixing tests
anupkalburgi f5214ca
changes to make file
anupkalburgi 0a8fa2a
updating docs
anupkalburgi 61f676d
fixing tests, removing the solved todos, targets to a diff module
anupkalburgi e139c8b
converting to camelCase
anupkalburgi 52a4283
validation into a diff module
anupkalburgi a0ce13b
removing compat/scratch notes
anupkalburgi f6c9a69
marking the spec module experimental
anupkalburgi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| """Pydantic-based specification API for dbldatagen (Experimental). | ||
|
|
||
| This module provides Pydantic models and specifications for defining data generation | ||
| in a type-safe, declarative way. | ||
|
|
||
| .. warning:: | ||
| Experimental - This API is experimental and both APIs and generated code | ||
| are liable to change in future versions. | ||
| """ | ||
|
|
||
| from typing import Any | ||
|
|
||
| # Import only the compat layer by default to avoid triggering Spark/heavy dependencies | ||
| from .compat import BaseModel, Field, constr, root_validator, validator | ||
|
|
||
|
|
||
| # Lazy imports for heavy modules - import these explicitly when needed | ||
| # from .column_spec import ColumnSpec | ||
| # from .generator_spec import GeneratorSpec | ||
| # from .generator_spec_impl import GeneratorSpecImpl | ||
|
|
||
| __all__ = [ | ||
| "BaseModel", | ||
| "ColumnDefinition", | ||
| "DatagenSpec", | ||
| "Field", | ||
| "Generator", | ||
| "constr", | ||
| "root_validator", | ||
| "validator", | ||
| ] | ||
|
|
||
|
|
||
| def __getattr__(name: str) -> Any: # noqa: ANN401 | ||
| """Lazy import heavy modules to avoid triggering Spark initialization. | ||
|
|
||
| Note: Imports are intentionally inside this function to enable lazy loading | ||
| and avoid importing heavy dependencies (pandas, IPython, Spark) until needed. | ||
| """ | ||
| if name == "ColumnSpec": | ||
| from .column_spec import ColumnDefinition # noqa: PLC0415 | ||
| return ColumnDefinition | ||
| elif name == "GeneratorSpec": | ||
| from .generator_spec import DatagenSpec # noqa: PLC0415 | ||
| return DatagenSpec | ||
| elif name == "GeneratorSpecImpl": | ||
| from .generator_spec_impl import Generator # noqa: PLC0415 | ||
| return Generator | ||
| raise AttributeError(f"module {__name__!r} has no attribute {name!r}") | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use absolute imports as a convention where possible. We're cleaning-up the relative-style imports in other modules.