Skip to content

Added validation for CSCwd40071#332

Open
sanjanch wants to merge 3 commits intodatacenter:masterfrom
sanjanch:CSCwd40071
Open

Added validation for CSCwd40071#332
sanjanch wants to merge 3 commits intodatacenter:masterfrom
sanjanch:CSCwd40071

Conversation

@sanjanch
Copy link
Contributor

@sanjanch sanjanch commented Jan 23, 2026

Apic Pass Log:

apic1# python3 aci-preupgrade-validation-script_sanjanch.py -d inband_management_policy_misconfig_check -c "5.3(2c)" -t "6.1(4h)"
==== 2026-01-23T05-10-56+0000, Script Version v4.0.1 ====

!!!! Check https://github.com/datacenter/ACI-Pre-Upgrade-Validation-Script for Latest Release !!!!

To use a non-default Login Domain, enter apic#DOMAIN\USERNAME
Enter username for APIC login : admin
Enter password for corresponding User :

Gathering Node Information...

Current version is overridden to 5.3(2c)

Target APIC version is overridden to 6.1(4h)

Collecting VPC Node IDs...

Progress: |████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 checks completed

=== Check Result (failed only) ===

=== Summary Result ===

PASS : 1
FAIL - OUTAGE WARNING!! : 0
FAIL - UPGRADE FAILURE!! : 0
MANUAL CHECK REQUIRED : 0
POST UPGRADE CHECK REQUIRED : 0
N/A : 0
ERROR !! : 0
TOTAL : 1

Pre-Upgrade Check Complete.
Next Steps: Address all checks flagged as FAIL, ERROR or MANUAL CHECK REQUIRED

Result output and debug info saved to below bundle for later reference.
Attach this bundle to Cisco TAC SRs opened to address the flagged checks.

  Result Bundle: /data/techsupport/preupgrade_validator_2026-01-23T05-10-56+0000.tgz

==== Script Version v4.0.1 FIN ====

Pytest Logs:

===================================================================== test session starts ======================================================================
platform linux -- Python 3.8.10, pytest-8.3.5, pluggy-1.5.0
rootdir: /data/ssd/sanjanch/repo/ACI_escalation/ACI-Pre-Upgrade-Validation-Script_sanjanch
configfile: pytest.ini
collected 10 items

test_inband_management_policy_misconfig_check.py::test_logic[icurl_outputs0-5.2(5c)-None-MANUAL CHECK REQUIRED]
------------------------------------------------------------------------ live log setup ------------------------------------------------------------------------
[05:17:08.998 INFO init_system:6081(MainThread)] Cleaning up previous run files in preupgrade_validator_logs/
[05:17:08.999 INFO init_system:6083(MainThread)] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
------------------------------------------------------------------------ live log call -------------------------------------------------------------------------
[05:17:09.001 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
[05:17:09.002 INFO _start_thread:1105(MainThread)] (inband_management_policy_misconfig_check) Starting thread.
[05:17:09.003 INFO wrapper:1349(inband_management_policy_misconfig_check)] Start inband_management_policy_misconfig_check
[05:17:09.004 INFO update_result:1191(inband_management_policy_misconfig_check)] Finalized result in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
PASSED [ 10%]
test_inband_management_policy_misconfig_check.py::test_logic[icurl_outputs1-6.0(3g)-6.0(4c)-PASS]
------------------------------------------------------------------------ live log call -------------------------------------------------------------------------
[05:17:09.019 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
[05:17:09.020 INFO _start_thread:1105(MainThread)] (inband_management_policy_misconfig_check) Starting thread.
[05:17:09.020 INFO wrapper:1349(inband_management_policy_misconfig_check)] Start inband_management_policy_misconfig_checkompleted
[05:17:09.021 INFO update_result:1191(inband_management_policy_misconfig_check)] Finalized result in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
PASSED [ 20%]
test_inband_management_policy_misconfig_check.py::test_logic[icurl_outputs2-6.0(3e)-6.0(8f)-PASS]
------------------------------------------------------------------------ live log call -------------------------------------------------------------------------
[05:17:09.034 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
[05:17:09.034 INFO _start_thread:1105(MainThread)] (inband_management_policy_misconfig_check) Starting thread.
[05:17:09.035 INFO wrapper:1349(inband_management_policy_misconfig_check)] Start inband_management_policy_misconfig_check
[05:17:09.037 INFO update_result:1191(inband_management_policy_misconfig_check)] Finalized result in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
PASSED [ 30%]
test_inband_management_policy_misconfig_check.py::test_logic[icurl_outputs3-6.0(4c)-6.0(5h)-N/A]
------------------------------------------------------------------------ live log call -------------------------------------------------------------------------
[05:17:09.048 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
[05:17:09.049 INFO _start_thread:1105(MainThread)] (inband_management_policy_misconfig_check) Starting thread.
[05:17:09.049 INFO wrapper:1349(inband_management_policy_misconfig_check)] Start inband_management_policy_misconfig_check
[05:17:09.050 INFO update_result:1191(inband_management_policy_misconfig_check)] Finalized result in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
PASSED [ 40%]
test_inband_management_policy_misconfig_check.py::test_logic[icurl_outputs4-6.0(5h)-6.0(5j)-N/A]
------------------------------------------------------------------------ live log call -------------------------------------------------------------------------
[05:17:09.062 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
[05:17:09.063 INFO _start_thread:1105(MainThread)] (inband_management_policy_misconfig_check) Starting thread.
[05:17:09.063 INFO wrapper:1349(inband_management_policy_misconfig_check)] Start inband_management_policy_misconfig_check
[05:17:09.065 INFO update_result:1191(inband_management_policy_misconfig_check)] Finalized result in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
PASSED [ 50%]
test_inband_management_policy_misconfig_check.py::test_logic[icurl_outputs5-6.0(5j)-6.0(6c)-N/A]
------------------------------------------------------------------------ live log call -------------------------------------------------------------------------
[05:17:09.076 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
[05:17:09.077 INFO _start_thread:1105(MainThread)] (inband_management_policy_misconfig_check) Starting thread.
[05:17:09.078 INFO wrapper:1349(inband_management_policy_misconfig_check)] Start inband_management_policy_misconfig_check
[05:17:09.078 INFO update_result:1191(inband_management_policy_misconfig_check)] Finalized result in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
PASSED [ 60%]
test_inband_management_policy_misconfig_check.py::test_logic[icurl_outputs6-6.0(3g)-6.0(3f)-N/A]
------------------------------------------------------------------------ live log call -------------------------------------------------------------------------
[05:17:09.092 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
[05:17:09.093 INFO _start_thread:1105(MainThread)] (inband_management_policy_misconfig_check) Starting thread.
[05:17:09.094 INFO wrapper:1349(inband_management_policy_misconfig_check)] Start inband_management_policy_misconfig_check
[05:17:09.095 INFO update_result:1191(inband_management_policy_misconfig_check)] Finalized result in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
PASSED [ 70%]
test_inband_management_policy_misconfig_check.py::test_logic[icurl_outputs7-6.0(3g)-6.0(4c)-FAIL - OUTAGE WARNING!!]
------------------------------------------------------------------------ live log call -------------------------------------------------------------------------
[05:17:09.107 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
[05:17:09.108 INFO _start_thread:1105(MainThread)] (inband_management_policy_misconfig_check) Starting thread.
[05:17:09.108 INFO wrapper:1349(inband_management_policy_misconfig_check)] Start inband_management_policy_misconfig_check
[05:17:09.111 INFO update_result:1191(inband_management_policy_misconfig_check)] Finalized result in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
PASSED [ 80%]
test_inband_management_policy_misconfig_check.py::test_logic[icurl_outputs8-5.3(2c)-6.1(4h)-FAIL - OUTAGE WARNING!!]
------------------------------------------------------------------------ live log call -------------------------------------------------------------------------
[05:17:09.122 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
[05:17:09.123 INFO _start_thread:1105(MainThread)] (inband_management_policy_misconfig_check) Starting thread.
[05:17:09.123 INFO wrapper:1349(inband_management_policy_misconfig_check)] Start inband_management_policy_misconfig_check
[05:17:09.125 INFO update_result:1191(inband_management_policy_misconfig_check)] Finalized result in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
PASSED [ 90%]
test_inband_management_policy_misconfig_check.py::test_logic[icurl_outputs9-5.2(8h)-6.1(3f)-FAIL - OUTAGE WARNING!!]
------------------------------------------------------------------------ live log call -------------------------------------------------------------------------
[05:17:09.137 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
[05:17:09.137 INFO _start_thread:1105(MainThread)] (inband_management_policy_misconfig_check) Starting thread.
[05:17:09.138 INFO wrapper:1349(inband_management_policy_misconfig_check)] Start inband_management_policy_misconfig_check
[05:17:09.139 INFO update_result:1191(inband_management_policy_misconfig_check)] Finalized result in preupgrade_validator_logs/json_results/inband_management_policy_misconfig_check.json
PASSED [100%]

====================================================================== 10 passed in 0.19s ======================================================================

@aciclaw
Copy link
Collaborator

aciclaw commented Feb 9, 2026

Looks good to me as per lab test.

@aciclaw aciclaw self-requested a review February 9, 2026 04:01
lovkeshsharma702
lovkeshsharma702 reviewed Mar 6, 2026
View reviewed changes
aci-preupgrade-validation-script.py
return Result(result=result, headers=headers, data=data, recommended_action=recommended_action, doc_url=doc_url)


@check_wrapper(check_title="Inband Management Policy Misconfiguration")
Copy link

@lovkeshsharma702 lovkeshsharma702 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it to mgmtRsInBStNode Missconfig check

aci-preupgrade-validation-script.py

@check_wrapper(check_title="Inband Management Policy Misconfiguration")
def inband_management_policy_misconfig_check(cversion, tversion, **kwargs):

Copy link

@lovkeshsharma702 lovkeshsharma702 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no extra space please.

aci-preupgrade-validation-script.py
recommended_action = " Contact Cisco TAC to remove any identified misconfigured 'mgmtRsInBStNode' objects"
doc_url = "https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#inband-management-policy-misconfiguration"

if not tversion:
Copy link

@lovkeshsharma702 lovkeshsharma702 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need this. if you don't use this portion, does it not ask for tversion?

aci-preupgrade-validation-script.py

if not tversion:
return Result(result=MANUAL, msg=TVER_MISSING)
if cversion.older_than("6.0(4c)") and (tversion.newer_than("6.0(4c)") or tversion.same_as("6.0(4c)")):
Copy link

@lovkeshsharma702 lovkeshsharma702 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cVersion doesn't matter in this case.

Copy link
Contributor Author

@sanjanch sanjanch Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the mail thread shared by Welkin, even though invalid config mgmtRsInBStNode was present on system before 6.0(4c) it did not affect it.

Due to the fix in CSCwh80837, when the APIC upgrade is triggered from 5.2(6g) to 6.0(9d), issue was hitting and introduced starting from 6.0(4c). The issue will only be triggered during upgrades crossing 6.0(4c) due to CSCwh80837. So we are checking the cversion less than 6.0(4c) as discussed with Welkin.

Could you please confirm?

aci-preupgrade-validation-script.py
result = PASS
headers = ["Node_ID", "Address", "Gateway"]
data = []
recommended_action = " Contact Cisco TAC to remove any identified misconfigured 'mgmtRsInBStNode' objects"
Copy link

@lovkeshsharma702 lovkeshsharma702 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no extra space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aciclaw aciclaw Awaiting requested review from aciclaw

1 more reviewer

@lovkeshsharma702 lovkeshsharma702 lovkeshsharma702 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sanjanch @aciclaw @lovkeshsharma702