feat: add Solidity compatibility enhancements#46
Open
allenday wants to merge 1 commit intodatachainlab:masterfrom
Open
feat: add Solidity compatibility enhancements#46allenday wants to merge 1 commit intodatachainlab:masterfrom
allenday wants to merge 1 commit intodatachainlab:masterfrom
Conversation
- Add comprehensive Solidity reserved keywords detection and mangling - Implement automatic field name mangling with _field suffix for conflicts - Fix boolean parameter parsing to support flag-style options (gen_runtime=true) - Update parameter processing to handle both boolean flags and value parameters - Add file path normalization for cross-platform compatibility - Update documentation with Solidity compatibility features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add Solidity compatibility enhancements
Summary
Changes
Reserved Keyword Handling
_fieldsuffix for conflictsEnhanced Parameter Processing
gen_runtime) and value parameters (gen_runtime=file.sol)Cross-platform Compatibility
Technical Details
Files Modified:
protobuf-solidity/src/protoc/plugin/gen_util.py- Added SOLIDITY_RESERVED_KEYWORDS set and mangle_solidity_field_name functionprotobuf-solidity/src/protoc/plugin/gen_sol.py- Fixed boolean parameter parsing for gen_runtime optionREADME.md- Added Solidity Compatibility documentation sectionKey Functions Added:
mangle_solidity_field_name()- Automatically mangles conflicting field namesparse_urllike_parameter()- Supports both boolean flags and value parametersTest Plan
Impact
This enhancement improves the plugin's robustness and usability, particularly for projects using buf toolchain and modern Solidity development practices. Field name conflicts are resolved automatically without manual intervention.
Backward Compatibility
All changes are backward compatible. Existing protobuf schemas and plugin configurations continue to work unchanged.