Move benchmark and ingestion files where they belong#25
Open
Conversation
cgoudet
approved these changes
Mar 18, 2026
Collaborator
cgoudet
left a comment
cgoudet
left a comment
There was a problem hiding this comment.
Merci pour ce boulot.
2-3 petits commentaires mais tu pourras merger direct après.
J'ai vu qu'il y avait pleins de pdf qui ont disparu. On les avait versionné par erreur avant?
| from hierarchical.postprocessor import ResultPostprocessor | ||
|
|
||
| from docling_postprocess import render_docling_output | ||
| from ..docling_postprocess import render_docling_output |
Collaborator
There was a problem hiding this comment.
Est ce que tu pourrais mettre partout des imports absolus?
| file and yield that path. Downstream (e.g. Docling) expects a path to a | ||
| real file on disk. | ||
| """ | ||
| from django.core.files.storage import default_storage |
Collaborator
There was a problem hiding this comment.
A moins qu'il y ait une raison très technique les imports sont mieux en haut de fichier.
| if benchmark_parsing_dir_str not in sys.path: | ||
| sys.path.insert(0, benchmark_parsing_dir_str) | ||
| parse_docling = importlib.import_module("benchmarking.parsers").parse_docling | ||
| from .benchmarking.parsers import parse_docling |
| ingestion/parsing/output/benchmark_results_extended.csv | ||
| ingestion/parsing/output/extraction_scores.csv | ||
| ingestion/parsing/output/analysis/ | ||
| eu_fact_force/ingestion/parsing/output/extracted_texts/ |
Collaborator
There was a problem hiding this comment.
Je pense qu'il est préférable de mettre les output dans un sous dossier de data/ pour ne pas mélanger du code et des données.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidy up the codebase, this is only moving files and resolving imports